Skip to content

Add support for changing from 12 to 24-hour time #15452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mafredri opened this issue Nov 8, 2024 · 4 comments · Fixed by #17016 or #17025
Closed

Add support for changing from 12 to 24-hour time #15452

mafredri opened this issue Nov 8, 2024 · 4 comments · Fixed by #17016 or #17025
Assignees

Comments

@mafredri
Copy link
Member

mafredri commented Nov 8, 2024

As a user I would like to view all times as 24-hour time as is common in my country (Finland).

On a personal note: I have never internalized the difference between 12AM and 12PM and I probably never will, it's very confusing because, to me, its meaning is a coin-toss.

Another part of this request is to stay consistent with the selection. All time should be formatted via a specific function that takes the user selection into account. In the screenshot below you can see that the notice is in 24-hour time and the inputs are 12-hour.

Image

@matifali
Copy link
Member

It could go along with the timezones discussion in #15519.

@mafredri
Copy link
Member Author

@matifali It's not directly related, although I suppose one could propose that a certain timezone could be weakly associated with a default 12- or 24-hour clock. But that's more specific to locale/country.

That said, if we zoom out from timezones then I think these settings are closely related.

@mtojek mtojek self-assigned this Mar 19, 2025
@mtojek
Copy link
Member

mtojek commented Mar 19, 2025

It looks like it's partially resolved. @mafredri, could you verify on your end?

Image

In my case, we need to format "Next occurrence" message.

@mtojek
Copy link
Member

mtojek commented Mar 20, 2025

@mafredri found that the internal implementation of time picker depends on the system locale. Let me see if we can use the same API for formatting purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants