Skip to content

chore: create a separate RBAC resource for WorkspaceModule #15543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hugodutka opened this issue Nov 16, 2024 · 0 comments
Open

chore: create a separate RBAC resource for WorkspaceModule #15543

hugodutka opened this issue Nov 16, 2024 · 0 comments
Labels
api Area: HTTP API needs decision Needs a higher-level decision to be unblocked.

Comments

@hugodutka
Copy link
Contributor

dbauthz functions like GetWorkspaceModulesByJobID check whether the caller has the rbac.ResourceSystem permission. This is fine for now as workspace modules are now used only in telemetry, but as they become used in other places they will need a separate RBAC resource.

Source comment: #15450 (comment)
@coder-labeler coder-labeler bot added api Area: HTTP API needs decision Needs a higher-level decision to be unblocked. labels Nov 16, 2024
@hugodutka hugodutka mentioned this issue Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Area: HTTP API needs decision Needs a higher-level decision to be unblocked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hugodutka