bug: newline append to ssh key #15672
Comments
|
Is this new behavior? If not then this is not a bug. Is it difficult for you to remove the newline using e.g. shell commands? I would consider this a breaking change to force every consumer of this API to now manually add the newline back if necessary for it's intended use case. |
I do not know if this is new behavior, but if it is intended, please make sure you put a warning note in the documentation that the API is appending a new line. I understand that it might break things, but adding a new line to a key does not seem right to me because the API's value is the SSH key itself, which should represent the key and not any modified data, which it now does due to the added new line. When using the ssh key, users should expect that it only contains the key not additional characters. Debugging was a pain because it was not documented. |
When requesting the user's SSH Key with the API (using Terraform script, curl), the response has a newline is appended to the SSH key, which is a bug to me because I have to remove it by hand for the key to work.
API Endpoint: /api/v2/users/me/gitsshkey
{ "user_id": "REDACTED", "created_at": "2024-07-12T18:09:58.597203+02:00", "updated_at": "2024-11-27T14:15:10.286881+01:00", "public_key": "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOBxIYrqi0vuWEnDlL0UzK4rHP/a/oJwF5mV5vkvZ9Gt\n" }This is a bug, without stripping the newline I cannot add the key to GitLab
The text was updated successfully, but these errors were encountered: