Skip to content

Users page shows confusing "Member" role #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1939
ammario opened this issue May 19, 2022 · 14 comments
Closed
Tracked by #1939

Users page shows confusing "Member" role #1593

ammario opened this issue May 19, 2022 · 14 comments
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@ammario
Copy link
Member

ammario commented May 19, 2022

Isn't everyone always a member? What does it mean to be a user on the website and not a member?
Screen Shot 2022-05-19 at 11 17 26 AM

@kylecarbs
Copy link
Member

@Emyrk we should probably remove that as a role in entirety and assume it by default, right?

@Emyrk
Copy link
Member

Emyrk commented May 19, 2022

We totally can do that lol.

@Emyrk
Copy link
Member

Emyrk commented May 19, 2022

Same with org-member

@misskniss misskniss added the site Area: frontend dashboard label May 24, 2022
@tjcran
Copy link

tjcran commented May 30, 2022

one use case could be if an "Auditor" was read-only for audit logs and didn't want the ability to create workspaces... but it seems unnecessary.

@misskniss
Copy link

Please add your planning poker estimate with ZenHub @Emyrk

@misskniss
Copy link

Please add your planning poker estimate with ZenHub @BrunoQuaresma

@Emyrk
Copy link
Member

Emyrk commented Jun 1, 2022

#1917

@tjcran
Copy link

tjcran commented Jun 1, 2022

closed via #1917

@tjcran tjcran closed this as completed Jun 1, 2022
@kylecarbs
Copy link
Member

image

@tjcran this still shows it on dev, and the attached PR is merged... I think something got messed up here.

@tjcran
Copy link

tjcran commented Jun 1, 2022

image

@tjcran this still shows it on dev, and the attached PR is merged... I think something got messed up here.

Are we sure dev is updated? That was only merged like 5 minutes ago @kylecarbs

@kylecarbs
Copy link
Member

Ahh my apologies, deployment is still running. You are correct!

@tjcran
Copy link

tjcran commented Jun 1, 2022

@Emyrk one issue that resulted here is that "members" only users now have a blank item in the role selector, which doesn't look great. I'm now wondering if it should still display "member" but not allow Member to be a selectable checkbox... What do you think?

@Emyrk
Copy link
Member

Emyrk commented Jun 1, 2022

@tjcran I noticed this too. This is a UX/UI question imo. We should not allow removing the "member" role for example, so the previous implementation was incorrect.

I think the UX might want to just place a "member" string if there is nothing present? I am ok with the FE team coming up with some placeholder solution, as that will be valid going forward.

So @presleyp @BrunoQuaresma ?

@tjcran
Copy link

tjcran commented Jun 1, 2022

@ammario closing this and handling it from FE team in #1949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

5 participants