Skip to content

chore: Remove dependabot #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ammario opened this issue May 23, 2022 · 6 comments
Closed

chore: Remove dependabot #1667

ammario opened this issue May 23, 2022 · 6 comments

Comments

@ammario
Copy link
Member

ammario commented May 23, 2022

cc @vapurrmaid

The majority of our pull requests are from dependabot making it annoying to sift through Pull Requests. Also, unless dependabot is submitting a security fix, an upgrade may just break the code (see Minimum Version Selection).

@ketang
Copy link
Contributor

ketang commented May 23, 2022

What's the alternative to this functionality? It serves a useful purpose. Is there a way to achieve the same goal less noisily? Perhaps we run it less often or have it bundle all changes for a period into a single PR (not sure it can), or something else?

@ammario
Copy link
Member Author

ammario commented May 23, 2022

Why do we need this functionality?

@ketang
Copy link
Contributor

ketang commented May 26, 2022

It keeps us from using dependencies that have vulnerabilities patched in later versions or that have passed their end of life maintenance status. Probably gets us bug fixes as well.

@ammario
Copy link
Member Author

ammario commented May 26, 2022

There's a trade off between bug fixes and PR noise. You may be surprised by how few bugs dependabot solves. But, the trade off is difficult to quantify. Since it primarily updates FE dependencies, I think the resolution is best left to someone on our FE team.

@ketang
Copy link
Contributor

ketang commented May 26, 2022

I haven't seen evidence that this causes problems. Maybe we can roll all the changes into a different branch:

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#target-branch

I'd want that branch to have a datestamp in its name, and I don't see a way to request merging that branch. I'm sure someone out there has scripts to do stuff like this.

@misskniss misskniss added needs decision Needs a higher-level decision to be unblocked. site Area: frontend dashboard needs grooming 🪒 labels Jun 1, 2022
@kylecarbs
Copy link
Member

I removed labels from dependabot here: #2110. This should help make it less visually spammy.

I agree with Ketan that dependabot is useful for vulnerabilities. This is a won't fix for now!

@kylecarbs kylecarbs closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2022
@misskniss misskniss added invalid and removed needs decision Needs a higher-level decision to be unblocked. site Area: frontend dashboard needs grooming labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants