Skip to content

bug: dashboard workspaces page spams the build timings endpoint #17188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
deansheather opened this issue Apr 1, 2025 · 3 comments · Fixed by #17590
Closed
1 task done

bug: dashboard workspaces page spams the build timings endpoint #17188

deansheather opened this issue Apr 1, 2025 · 3 comments · Fixed by #17590
Assignees
@BrunoQuaresma
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@deansheather
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Opening a running workspace in the dashboard seems to spam the build timings endpoint once per second.

GET /api/v2/workspacebuilds/xyz/timings

I'm not sure if this is necessary but it seems over the top/unintended.

Image

Relevant Log Output



Expected Behavior


No spam


Steps to Reproduce


    

  1. Open a running workspace in the dashboard
    2. 



Environment


    

  • Host OS: Windows Firefox
    • 

  • Coder version: main
    • 



Additional Context


No response

      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @deansheather
deansheather




          added
  the 

  needs-triage

  Issue that require triage
 label


      Apr 1, 2025

    

  



    

    

      
    

    


      

          @matifali
matifali




            added
      

  s3

  Bugs that confuse, annoy, or are purely cosmetic

      

  s4

  Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

      

  customer-reported

  Bugs reported by enterprise customers. Only humans may set this.

    and removed
      

  needs-triage

  Issue that require triage

      

  s4

  Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

  labels


      Apr 1, 2025

    

  








      

  
      



  

  @matifali





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            matifali
  

      

      

      commented


        Apr 7, 2025


      
    


  





      


        


  
    

      
          
Looks similar and related to the following:


    

  1. UI memory leak on a workspace detail page #15921
    2. 

  2. Cannot render workspace build timeline > provisioning > apply stage #16409
    3. 

  3. Build timeline scale looks bad for long (multiple minute) builds #15374
    4. 


      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
      



  

  @dannykopping





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            dannykopping
  

      

      

      commented


        Apr 9, 2025


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

    
  



    


  





      


        


  
    

      
          
I think we should convert this into a Server-Sent Events/WebSocket endpoint to be consistent with other approaches (e.g. /workspacebuilds/{workspacebuild}/logs).

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            


    

    

      
    

    


      

          @matifali
matifali




          removed
  the 

  customer-reported

  Bugs reported by enterprise customers. Only humans may set this.
 label


      Apr 9, 2025

    

  



    







      

  
      



  

  @BrunoQuaresma





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
I can do a quick fix in the FE side but I like the idea that @dannykopping suggested.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            

    

      
    

    


      

          @BrunoQuaresma
BrunoQuaresma




              self-assigned this


      Apr 28, 2025

    

  



  

  

    
  


  

      

    @BrunoQuaresma
BrunoQuaresma



    mentioned this issue
    
      Apr 28, 2025
    





  


  

      
   Merged

  







  




    

    


    

    


  









  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @BrunoQuaresma
  
    BrunoQuaresma
    

      








      


  


  

    Labels
  



    

      

    s3

  Bugs that confuse, annoy, or are purely cosmetic








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: fix script timings spam in the workspace UI

    
      coder/coder
    





      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @dannykopping 
        
          @BrunoQuaresma 
        
          @matifali 
        
          @deansheather