Skip to content

Default to downloading Terraform when the system has different minor version #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AbhineetJain opened this issue May 25, 2022 · 3 comments · Fixed by #1775
Closed

Default to downloading Terraform when the system has different minor version #1743

AbhineetJain opened this issue May 25, 2022 · 3 comments · Fixed by #1775
Labels
api Area: HTTP API

Comments

@AbhineetJain
Copy link
Contributor

AbhineetJain commented May 25, 2022 •
edited
Loading

What is your suggestion?

When the user's systems have a Terraform version with a different minor version, we want to install the version that Coder uses (currently 1.1). We should support different patch versions within 1.1.

Why do you want this feature?

Things might break if we don't run Terraform with the minor version currently used.

Are there any workarounds to get this functionality today?

The only workaround is for the consumer systems to install Terraform 1.1 versions.

Are you interested in submitting a PR for this?

Yes
@AbhineetJain AbhineetJain mentioned this issue May 25, 2022
Merged
1 task
@coadler
Copy link
Contributor

coadler commented May 25, 2022

Maybe a warning would suffice?

@AbhineetJain
Copy link
Contributor Author

So just a warning that some functionalities might not work properly? That does sound like a nice UX fix. But we need not ask the user to switch their local version to match our requirement. We download Terraform anyway when it is not found in the system, we can still download and use it if we find a different version installed. 🤔

@AbhineetJain
Copy link
Contributor Author

I just discovered that our provisioner/terraform unit tests also fail when using the wrong minor version (latest, v1.2.1).

@AbhineetJain AbhineetJain mentioned this issue May 26, 2022
Merged
3 tasks
@kylecarbs kylecarbs changed the title feat: Default to downloading Terraform when the system has different minor version Default to downloading Terraform when the system has different minor version Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Area: HTTP API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Download default terraform version when minor version mismatches coder/coder
2 participants
@coadler @AbhineetJain