Skip to content

All org users should have access to the user list for their own org in the UI #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1101
misskniss opened this issue May 25, 2022 · 6 comments · Fixed by #1797
Closed
Tracked by #1101

All org users should have access to the user list for their own org in the UI #1746

misskniss opened this issue May 25, 2022 · 6 comments · Fixed by #1797
Assignees
@Kira-Pilot
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@misskniss
Copy link

misskniss commented May 25, 2022 •
edited
Loading

As an org member, I want the ability to navigate to the users page in the UI so that I can see all the other users in my org.

Right now, a non-admin member of an org would have to manaully enter the URL for the users page since the current link that page is in the Admin menu that will not be visible to non-admin roles. So we need a button or menu list item somewhere for non-admins to get to this page.

In this image, my role was Member only and I could only get to this page by manually entering the URL without the admin dropdown.

Non-Admin user page view.png

Implementation Details:

  • Move the Users list to the Top Nav to the right of the Templates link
  • Non-Admin users will see all other users in their org but will only have read access to users and each users role
  • Admins will have all the usual permissions to read/update/delete/change password for users in the list

(This is related to issue #1742 as well. )
@misskniss misskniss added this to the Community MVP milestone May 25, 2022
@misskniss misskniss mentioned this issue May 25, 2022
Closed
45 tasks
@misskniss misskniss added Community MVP 🏁 site Area: frontend dashboard labels May 25, 2022
@misskniss
Copy link
Author

@BrunoQuaresma This is the issue where we should decide as a team where the best place in the UI would be to put a link to this page for our non-admins.
CC @tjcran

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented May 25, 2022 •
edited
Loading

Hmm... it should be done in the FE. Probably the BE is not allowing a member user to read all the users. I think it is probably a role issue on RBAC cc: @Emyrk. It is being checked here:

coder/site/src/xServices/auth/authXService.ts

Lines 18 to 24 in 3f770e1

export const permissionsToCheck = {
[checks.readAllUsers]: {
object: {
resource_type: "user",
},
action: "read",
},

@BrunoQuaresma
Copy link
Collaborator

Ahh, no backend issue. The admin dropdown is displayed if the user has that permission to update users. What makes sense... what we probably want to do is to move the "Users" nav to the main navbar and check the readUsers permission as we do here:

coder/site/src/components/Navbar/Navbar.tsx

Lines 11 to 14 in 3f770e1

const permissions = useSelector(xServices.authXService, selectPermissions)
// When we have more options in the admin dropdown we may want to check this
// for more permissions
const displayAdminDropdown = !!permissions?.updateUsers

@Emyrk
Copy link
Member

Emyrk commented May 25, 2022

@misskniss there is only 1 organization for MVP. So isn't the admin page the same page for all users? Like the actual page is the exact same for both types of user. (member and admin)

@ketang
Copy link
Contributor

ketang commented May 25, 2022

I question whether this is a switch blocker.

@tjcran
Copy link

tjcran commented May 25, 2022

The solution agreed upon is that we will be removing the Admin dropdown from the topnav and move the "Users" menu to the topnav next to templates. The Users page will be the same for both admins and non-admins, but only admins will be able to "do stuff" via the RBAC, which is already in place anyway.

@Kira-Pilot Kira-Pilot self-assigned this May 25, 2022
Kira-Pilot added a commit that referenced this issue May 26, 2022
@Kira-Pilot
chore: add users link to nav bar
8c64457 
resolves #1746
@Kira-Pilot Kira-Pilot mentioned this issue May 26, 2022
Merged
Kira-Pilot added a commit that referenced this issue May 26, 2022
@Kira-Pilot
chore: add users link to nav bar (#1797)
b4c41d3 
* chore: add users link to nav bar

resolves #1746

* fix test names
kylecarbs pushed a commit that referenced this issue Jun 10, 2022
@Kira-Pilot @kylecarbs
chore: add users link to nav bar (#1797)
475031a 
* chore: add users link to nav bar

resolves #1746

* fix test names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

chore: add users link to nav bar coder/coder
6 participants
@ketang @misskniss @BrunoQuaresma @Emyrk @tjcran @Kira-Pilot