Skip to content

Implement Provisioner Keys view under Organizations #17698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bartekgatzcoder opened this issue May 7, 2025 · 6 comments · Fixed by #17889
Closed

Implement Provisioner Keys view under Organizations #17698

bartekgatzcoder opened this issue May 7, 2025 · 6 comments · Fixed by #17889
Assignees
@johnstcn
Labels
provisioners

Comments

@bartekgatzcoder
Copy link
Contributor

This task is for the implementation of ProductBoard item: https://coder.productboard.com/detail/MTpQbUVudGl0eTpiNDMyNzFkMS0yMzExLTQwN2EtYjRlMy01MjczNGU2MWVkNzc=

The goal of this sub-feature is to add the new page for listing Provisioner Keys.

The page should be linked to Provisioner Daemons:

  • each key (even and empty set) should be shown
  • keys with Daemons inside should link to pre-filtered Provisioner Daemons page based on filter with Provisioner Key

The page does not need any other interactions besides allowing for listing all Keys and linking them. Empty sets should be marked accordingly.
@BrunoQuaresma
Copy link
Collaborator

To get this done, we would need to add an endpoint to return all the provisioner keys. If the number of records is just around 100 or less, we can do the filtering only using the UI. It would be the same for the daemons endpoint.

@bartekgatzcoder
Copy link
Contributor Author

@mafredri can you take a look at the current API?

@BrunoQuaresma the number of provisioner keys should not be SO long. I suppose more than 100 will just be hard to manage anyways.

@mafredri
Copy link
Member

mafredri commented May 7, 2025

@BrunoQuaresma I believe the endpoint you're asking for already exists: https://dev.coder.com/api/v2/organizations/coder/provisionerkeys (GET, s/coder/{org}/), however it only exists on enterprise coderd at the moment. It's an enterprise feature so perhaps that won't be a problem.

@BrunoQuaresma
Copy link
Collaborator

Ahh ok, I was just looking for it in coderd.go. Thanks @mafredri !

@defelmnq
Copy link
Contributor

For visibility @BrunoQuaresma @bartekgatzcoder - are we good with the currently available endpoints and their scope ? (enterprise only.)

@bartekgatzcoder
Copy link
Contributor Author

@defelmnq this is a premium feature, so all is good.

@DanielleMaywood DanielleMaywood assigned johnstcn and unassigned defelmnq May 12, 2025
@johnstcn johnstcn mentioned this issue May 16, 2025
Merged
johnstcn added a commit that referenced this issue May 19, 2025
@johnstcn @BrunoQuaresma
feat: add Organization Provisioner Keys view (#17889)
ac7961a 
Fixes #17698

**Demo:**


https://github.com/user-attachments/assets/ba92693f-29b7-43ee-8d69-3d77214f3230

---------

Co-authored-by: BrunoQuaresma <bruno_nonato_quaresma@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
provisioners
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Organization Provisioner Keys view coder/coder
5 participants
@mafredri @BrunoQuaresma @johnstcn @defelmnq @bartekgatzcoder