Skip to content

Make deleting from a slice a generic function #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AbhineetJain opened this issue May 26, 2022 · 1 comment
Closed

Make deleting from a slice a generic function #1780

AbhineetJain opened this issue May 26, 2022 · 1 comment

Comments

@AbhineetJain
Copy link
Contributor

We should really make deleting from a slice a generic function imo. No need in this PR, just a comment

Originally posted by @Emyrk in #1770 (comment)

Instances:

And another instance in #1770.
@AbhineetJain AbhineetJain mentioned this issue May 26, 2022
Merged
4 tasks
@dwahler
Copy link
Contributor

dwahler commented May 26, 2022

Might want to just use golang.org/x/exp/slices.Delete(), which is planned to become part of the standard library in Go 1.19.

@kylecarbs kylecarbs changed the title Refactor: Make deleting from a slice a generic function Make deleting from a slice a generic function Jun 7, 2022
@kylecarbs kylecarbs added the chore label Jun 7, 2022
@f0ssel f0ssel mentioned this issue Jul 28, 2022
Closed
@f0ssel f0ssel closed this as completed Jul 28, 2022
@f0ssel f0ssel closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
@misskniss misskniss added invalid and removed api Area: HTTP API chore labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dwahler @misskniss @kylecarbs @AbhineetJain @f0ssel