-
Notifications
You must be signed in to change notification settings - Fork 886
UX: Replace native time picker with MUI Time Picker #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Which browsers do you think have problems? |
@tjcran may have alternatives or other views, I somewhat created this ticket on his behalf in response to feedback. I personally feel that the MUI TimePickers are a pleasing UX. Is it absolutely critical to do now? No. |
Okay then maybe I should ask the opposite: in which browsers does it work well? |
I don't know / am unsure it works well in dark theme on any of them |
I think this is important to get right for Community launch, not by Friday this week. |
A downside here is that I don't think that MUI Time Picker modal has keyboard support. Maybe we could tweak it so it behaves, or disable the modal itself on keyboard only. Is it a pain to just change the color of the little clock icon in the existing timepicker? SO claims we can do it with a filter, but I haven't tried it or tested it cross browser. |
@vapurrmaid tells me the color of the clock can't be changed, and it's impossible to see on the dark mode background.. I'm open to other alternatives, though. whatever makes it easiest for users to understand how to change the time using an actual time picker. |
Turns out I just didn't figure out how in my pass, but @Kira-Pilot sure as heck did (:tada:)!! |
User Story 👥
Our Workspace Schedule form uses a native
<input type="time">
picker. Unfortunately, it's hard to make this appearance sit well on all browsers in our dark theme, and folx might not be able to see the dark clock against the dark theme.<input type="time">
here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time#appearanceInstead of this less-than-stellar design, I'd love to see a TimePicker like I see in modern mobile applications.
https://material-ui-pickers.dev/demo/timepicker#time-picker
Note
The underlying data representation should not change, we use
HH:mm
(24 hour format).The text was updated successfully, but these errors were encountered: