feat: add stop workspace button with confirmation dialog #18372
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add stop workspace button with square icon that replaces start button for running workspaces - Implement confirmation dialog for stop operation to prevent accidental stops - Button shows only when workspace status allows stop action - Uses existing stopWorkspace API mutation - Follows existing UI patterns for workspace actions Fixes #18298 Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Adds a stop workspace button with a confirmation dialog to complement the existing start button and prevent accidental stops.
- Introduces a stop action button (square icon) shown for running workspaces.
- Implements a confirmation dialog that prompts before calling the
stopWorkspacemutation. - Leverages existing API mutation and workspace status logic for visibility and loading indicators.
Comments suppressed due to low confidence (1)
site/src/pages/WorkspacesPage/WorkspacesTable.tsx:594
- Add tests to cover the stop workspace confirmation dialog: verify it opens on button click, displays the correct workspace name, and invokes the
stopWorkspacemutation on confirm.
<ConfirmDialog
| {abilities.actions.includes("stop") && ( | ||
| <PrimaryAction | ||
| onClick={() => setIsStopConfirmOpen(true)} | ||
| isLoading={stopWorkspaceMutation.isPending} |
There was a problem hiding this comment.
Consider disabling the stop button while stopWorkspaceMutation is pending (e.g., pass a disabled prop to PrimaryAction or the underlying Button) to prevent duplicate clicks during the loading state.
Suggested change
| isLoading={stopWorkspaceMutation.isPending} | |
| isLoading={stopWorkspaceMutation.isPending} | |
| disabled={stopWorkspaceMutation.isPending} |
Copilot uses AI. Check for mistakes.
- Add disabled prop to PrimaryActionProps interface - Implement disabled state in PrimaryAction component - Apply disabled prop to stop button when stopWorkspaceMutation is pending - Prevents accidental duplicate stop requests during operation Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
- ConfirmDialog component doesn't accept loading prop - Fixes TypeScript compilation error in CI - Button disabled state still prevents duplicate clicks Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
|
@matifali I'm in a rush with the website right now, so I will not have time this weeek to QA and review this PR. Maybe someone in the FE guild, can help with that in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a stop workspace button with confirmation dialog to complement the existing start button, addressing the feature request in #18298.
Changes
stopWorkspaceAPI mutationBehavior
Testing
Fixes #18298