feat: add stop workspace button with confirmation dialog #18372
Conversation
- Add stop workspace button with square icon that replaces start button for running workspaces - Implement confirmation dialog for stop operation to prevent accidental stops - Button shows only when workspace status allows stop action - Uses existing stopWorkspace API mutation - Follows existing UI patterns for workspace actions Fixes #18298 Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Adds a stop workspace button with a confirmation dialog to complement the existing start button and prevent accidental stops.
- Introduces a stop action button (square icon) shown for running workspaces.
- Implements a confirmation dialog that prompts before calling the
stopWorkspacemutation. - Leverages existing API mutation and workspace status logic for visibility and loading indicators.
Comments suppressed due to low confidence (1)
site/src/pages/WorkspacesPage/WorkspacesTable.tsx:594
- Add tests to cover the stop workspace confirmation dialog: verify it opens on button click, displays the correct workspace name, and invokes the
stopWorkspacemutation on confirm.
<ConfirmDialog
- Add disabled prop to PrimaryActionProps interface - Implement disabled state in PrimaryAction component - Apply disabled prop to stop button when stopWorkspaceMutation is pending - Prevents accidental duplicate stop requests during operation Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
- ConfirmDialog component doesn't accept loading prop - Fixes TypeScript compilation error in CI - Button disabled state still prevents duplicate clicks Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
|
@matifali I'm in a rush with the website right now, so I will not have time this weeek to QA and review this PR. Maybe someone in the FE guild, can help with that in the meantime. |
There was a problem hiding this comment.
Works, but we should remove the disabled prop and just use isLoading for disablement.
Technically it might not even be necessary as a state change removes the button, but there could be some latency where the workspace is stoping and the state has not updated on the frontend yet.
Use isLoading for button disabling instead of separate disabled prop. This simplifies the component interface while maintaining the same functionality - the button is disabled when loading. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
|
Also @matifali just to check, we have no confirmation dialog for stopping on the main workspace page (or any other actions on this table), just confirming that it was intended we add one here. |
|
Good point about consistency! You're right that other actions on this page don't have confirmation dialogs. Looking at the original feature request in #18298, it specifically mentioned wanting a confirmation dialog to prevent accidental stops. However, for consistency with the rest of the workspaces table actions, we could remove the confirmation dialog. Would you prefer I remove the confirmation dialog to match the existing pattern, or keep it since stopping a workspace is a more disruptive action than starting one? |
Remove empty line left after removing disabled prop to satisfy biome formatter requirements. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
|
This is a more accessible button, so IMO, there is a greater chance of hitting stop by accident, which is why I added the confirmation dialogue. |
Remove the disabled prop from PrimaryActionProps interface and component implementation since we now only use isLoading for button disabling. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Summary
Adds a stop workspace button with confirmation dialog to complement the existing start button, addressing the feature request in #18298.
Changes
stopWorkspaceAPI mutationBehavior
Testing
Fixes #18298