-
Notifications
You must be signed in to change notification settings - Fork 881
Decide how to handle canceling builds #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd call that a failed job, same as if there were no cancelled job. |
A "delete" also involves a job. Is this still considered a build/action? Can we cancel it? |
What are the exact decisions needed here? I'm happy to try and weigh in. |
I would like to include when this decision should take effect. Is this something that we are trying to bring in for Community? If so, go ahead and label it for Community. |
@misskniss this is not needed for Community. I just wanted to create a place for the discussion to live. @spikecurtis @f0ssel sorry, I stopped a little short because I realized this isn't a priority just yet. Yes, delete has to be considered as well because it can also be canceled. Spike, it sounds like you might be proposing a change to the API rather than just the frontend, where it sends back a failed job status if a double job (cancel then something) partially fails. That dovetails with Garrett's push to have the frontend do less derivation. |
As long as we have cancellation functionality with a name that users can understand, we can take as long as we want. I think cancellation is necessary for Community, but perfectly-named cancellation is not. |
Leaving this as is for Community. We can come back to it. |
Oh yikes, having both start and stop is not good not at all. |
Wait, why? If I cancel a Start, why is it wrong to Start again? Why is it wrong to Stop? |
If your workspace incarnation |
Start / Stop / Delete are being shown after the Action is cancelled, not while the workspace is stopping. I agree that if the Stop |
In that situation you shouldn't be able to run Start, so it avoids the problem of having Start and Stop buttons simultaneously. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
Here are some notes on how we might implement @spikecurtis's idea of not exposing
cancel
jobs alone to the user, but rather always pairing them withstart
orstop
jobs so that the workspace is always in a meaningful state. One potential issue is that thecancel
job could succeed and thestart
orstop
job fail, so thecanceled
state may not be totally avoidable.Reasons a user might want to cancel a
start
job and buttons they want in that scenario (button label in bold and then API requests it would call:Reasons a user might want to cancel a
stop
job and buttons:The text was updated successfully, but these errors were encountered: