UX: Workspace Schedule Form is too top-down restricted

## User Story 👥 

A real user story (thanks @ammario :tada:):

> Allow setting "Days of Week" when "Start time" is unset
This one confused me. We shouldn't assume that users will fill out the form in top to bottom order.

## Implementation Notes

Under the hood, the form has logic like:

https://github.com/coder/coder/blob/b85de3ee7972d30e129319c487909e72c107d206/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx#L192

At the parent level, whereby the form values are transformed into an API request, nothing should change:

https://github.com/coder/coder/blob/b85de3ee7972d30e129319c487909e72c107d206/site/src/pages/WorkspaceSchedulePage/WorkspaceSchedulePage.tsx#L24-L92



	export const formValuesToAutoStartRequest = (
	values: WorkspaceScheduleFormValues,
	): TypesGen.UpdateWorkspaceAutostartRequest => {
	if (!values.startTime) {
	return {
	schedule: "",
	}
	}

	const [HH, mm] = values.startTime.split(":")

	// Note: Space after CRON_TZ if timezone is defined
	const preparedTZ = values.timezone ? `CRON_TZ=${values.timezone} ` : ""

	const makeCronString = (dow: string) => `${preparedTZ}${mm} ${HH} * * ${dow}`

	const days = [
	values.sunday,
	values.monday,
	values.tuesday,
	values.wednesday,
	values.thursday,
	values.friday,
	values.saturday,
	]

	const isEveryDay = days.every((day) => day)

	const isMonThroughFri =
	!values.sunday &&
	values.monday &&
	values.tuesday &&
	values.wednesday &&
	values.thursday &&
	values.friday &&
	!values.saturday &&
	!values.sunday

	// Handle special cases, falling through to comma-separation
	if (isEveryDay) {
	return {
	schedule: makeCronString("*"),
	}
	} else if (isMonThroughFri) {
	return {
	schedule: makeCronString("1-5"),
	}
	} else {
	const dow = days.reduce((previous, current, idx) => {
	if (!current) {
	return previous
	} else {
	const prefix = previous ? "," : ""
	return previous + prefix + idx
	}
	}, "")

	return {
	schedule: makeCronString(dow),
	}
	}
	}

	export const formValuesToTTLRequest = (values: WorkspaceScheduleFormValues): TypesGen.UpdateWorkspaceTTLRequest => {
	return {
	// minutes to nanoseconds
	ttl: values.ttl ? values.ttl * 60 * 60 * 1000 * 1_000_000 : undefined,
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UX: Workspace Schedule Form is too top-down restricted #1958

User Story 👥

Implementation Notes

1 remaining item

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

UX: Workspace Schedule Form is too top-down restricted #1958

Description

User Story 👥

Implementation Notes

Activity

1 remaining item

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions