Skip to content

Catch and log panics in HTTP handlers #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Jun 1, 2022 · 1 comment
Closed

Catch and log panics in HTTP handlers #1974

spikecurtis opened this issue Jun 1, 2022 · 1 comment
Labels
api Area: HTTP API stale This issue is like stale bread.

Comments

@spikecurtis
Copy link
Contributor

Right now, if any of our HTTP handlers hits a panic, we silently swallow it with no logs. Not great for detecting errors!

Also the HTTP client calling the endpoint just gets no response, and it would be nice to reply with a 500 Internal Server Error.
@spikecurtis spikecurtis mentioned this issue Jun 2, 2022
Merged
@kylecarbs kylecarbs changed the title chore: catch and log panics in HTTP handlers Catch and log panics in HTTP handlers Jun 7, 2022
@kylecarbs kylecarbs added the chore label Jun 7, 2022
@misskniss misskniss added needs grooming api Area: HTTP API labels Jun 14, 2022
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Area: HTTP API stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@misskniss @spikecurtis @kylecarbs