Skip to content

Unclear admin persmissions: Admin can use Open terminal link on other users workspaces, but terminal is opened with Web Socket error #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1939
nadzeyav opened this issue Jun 2, 2022 · 1 comment · Fixed by #2114
Closed
Tracked by #1939

Unclear admin persmissions: Admin can use Open terminal link on other users workspaces, but terminal is opened with Web Socket error #1988

nadzeyav opened this issue Jun 2, 2022 · 1 comment · Fixed by #2114
Assignees
@AbhineetJain
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@nadzeyav
Copy link

nadzeyav commented Jun 2, 2022

OS Information

Steps to Reproduce

  1. Login as user with role Member and create a workspace
  2. Login as Admin
  3. Open member's workspace
  4. Click link Open Terminal link

Expected

Terminal is opened or link to open should be not displayed in case Admin should not be able to connect

Actual

Web Socket error (see screenshot)

Logs

Screenshot

image

Notes

have this issue in --dev mode, did not verify on production version
@tjcran tjcran added this to the Community MVP milestone Jun 2, 2022
@misskniss misskniss mentioned this issue Jun 2, 2022
Closed
90 tasks
@tjcran
Copy link

tjcran commented Jun 3, 2022

Acceptance Criteria: The terminal link/icon should only be visible to the owner of the workspace when viewing the workspace page

@f0ssel f0ssel added the site Area: frontend dashboard label Jun 6, 2022
@kylecarbs kylecarbs changed the title Bug: Unclear admin persmissions: Admin can use Open terminal link on other users workspaces, but terminal is opened with Web Socket error Unclear admin persmissions: Admin can use Open terminal link on other users workspaces, but terminal is opened with Web Socket error Jun 7, 2022
@AbhineetJain AbhineetJain self-assigned this Jun 7, 2022
@AbhineetJain AbhineetJain mentioned this issue Jun 7, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhineetJain AbhineetJain

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

feat: Allow admins to access member workspace terminals coder/coder
5 participants
@misskniss @tjcran @AbhineetJain @nadzeyav @f0ssel