Skip to content

Entering minutes field in workspace schedule start time triggers day of week validation failure #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1939
, #1317
...
ketang opened this issue Jun 3, 2022 · 5 comments
Closed
Tracked by #1939
, #1317
...

Entering minutes field in workspace schedule start time triggers day of week validation failure #2030

ketang opened this issue Jun 3, 2022 · 5 comments
Assignees
@johnstcn
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@ketang
Copy link
Contributor

ketang commented Jun 3, 2022

OS Information

Mac OS X
Chrome Version 101.0.4951.64 (Official Build) (arm64)
Coder v0.0.0-devel+d6e9eab

Steps to Reproduce

  1. From a workspace page, click Edit Schedule
  2. Click the "start time" field to give it focus
  3. Type a value for hours, e.g. 10
  4. Type a value for minutes, e.g 3

Expected

Days of week stay chill; I'll get to you.

Actual

Happy
Screen Shot 2022-06-03 at 16 52 45

One 3 later: sad.
Screen Shot 2022-06-03 at 16 52 53
@greyscaled
Copy link
Contributor

I do not think this is a bug.

@ketang
Copy link
Contributor Author

ketang commented Jun 3, 2022

Why not? I shouldn't be chastised for not selecting days of the week if I haven't gotten to that part of the form.

Also, even if that were the case, why wouldn't it be in that error state from the start? Why does it happen when I go from just hours to hours and minutes?

@greyscaled
Copy link
Contributor

I misunderstood, it's that the validation is happening before it's touched. I will change this back over to a bug.

@greyscaled greyscaled added bug 🐛 site Area: frontend dashboard and removed invalid 😿 labels Jun 6, 2022
@kylecarbs kylecarbs changed the title Bug: entering minutes field in workspace schedule start time triggers day of week validation failure Entering minutes field in workspace schedule start time triggers day of week validation failure Jun 7, 2022
@tjcran tjcran mentioned this issue Jun 13, 2022
Closed
90 tasks
@misskniss misskniss added this to the Community MVP milestone Jun 14, 2022
@misskniss misskniss mentioned this issue Jun 14, 2022
Closed
20 tasks
@johnstcn
Copy link
Member

Please add your planning poker estimate with ZenHub @vapurrmaid

@misskniss misskniss assigned greyscaled and unassigned greyscaled Jun 14, 2022
@johnstcn johnstcn self-assigned this Jun 22, 2022
@johnstcn johnstcn mentioned this issue Jul 1, 2022
Closed
@misskniss misskniss mentioned this issue Jul 19, 2022
Closed
20 tasks
@johnstcn
Copy link
Member

I'm no longer able to reproduce this issue. Opening the schedule and un-checking/deleting everything, and then just entering '1' in the 'hours' field no longer triggers a validation error. Entering both hours and minutes then triggers the day-of-week validation, which is required if you set the minute and hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

No branches or pull requests
5 participants
@ketang @misskniss @johnstcn @tjcran @greyscaled