-
Notifications
You must be signed in to change notification settings - Fork 881
Tighten up Workspace>Schedule section layout #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue should be solved in tandem with #2141. |
To solve this, I came up with some solutions:
I need to design the actions dropdown but I would like to receive early feedback. |
I'm a big fan of this style. Only a single minor nit: The "start / stopped" indicator should be a bit louder (maybe we merge it with the start/stop button itself somehow)? It seems like the status is difficult to parse. |
@kylecarbs yes, I agree. I will play around with other statuses to see. Figma link: https://www.figma.com/file/YIGBkXUcnRGz2ZKNmLaJQf/Coder-v2-Design?node-id=441%3A567 |
This seems like a big improvement! I really love how clean it looks. I think it's brilliant to combine the schedule stuff with the start button.
|
@Kira-Pilot great concerns! I think the popover should always be accessible and should open when a user "focuses" the element as well and not only "hovering" so users using the keyboard could navigate/use it as well. What do you think? And by "popover" I want to say a "dropdown that has something else than links" 😆 |
@BrunoQuaresma thats exactly what I was getting at! Sounds perfect to me! |
Suggestion: when workspace is running AND has a deadline set, the stop time (or a countdown?) should remain visible. |
@BrunoQuaresma the new design looks good!
|
@BrunoQuaresma I think the 'plus' and 'minus' version is clearer than the 'up and down' version, personally :-) |
Would this also address #2716? |
@ammario do you think the latest design is good enough? and any preferences about arrows or plus/minus? After getting approval I think we can create two tickets:
|
@BrunoQuaresma LGTM with +/- as Cian said. When the workspace is off can it flip to showing "Starts at" instead? We would have to hide the bumpers in this case since there's no support for one-off changing start time. |
@tjcran how do you prefer to handle this:
|
@BrunoQuaresma what if when you clicked on the "Stops at" time or the "Starts at" time it opened up a time selector like so? Hopefully we could reuse the component on the edit schedule page too... Or maybe there's even a way we could do without the edit schedule page. |
@ammario I think a time selector like this would not be possible because our "time selection" is a bit more complex. You don't define a date, you define a start time, the number of hours the workspace will be live, and days of the week. But to have an "inline edition" experience, we could try to make the form simpler and add it inside of a dropdown/popover. |
I may not be representative of our users, but for time fields I find typing to be faster than using a picker. How about we see if people ask for a picker? |
@BrunoQuaresma the second option! |
The design work is done and two tickets were created for the development part:
cc.: @tjcran |
Context
The text was updated successfully, but these errors were encountered: