Skip to content

Consolidate auto off extension UI #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ammario opened this issue Jun 8, 2022 · 6 comments
Closed

Consolidate auto off extension UI #2175

ammario opened this issue Jun 8, 2022 · 6 comments
Assignees
Labels
site Area: frontend dashboard stale This issue is like stale bread.

Comments

@ammario
Copy link
Member

ammario commented Jun 8, 2022

As per the decision in #2141 we should allow bumping the auto off whenever the user wants (except beyond the template constraints), instead of just before the workspace is shutting down.

Furthermore, we should allow the user to set a time for shutdown (instead of or in addition to?) extend by a duration. We could also make the following field editable so no additional UI components are necessary.

image

Also the Shutdown block needs to share the timezone, otherwise the user will assume it's the Start timezone. And again, we should use the browser timezone instead of the Auto Start configured timezone. The browser timezone is more likely to represent where the user is located on page load.


Additional nitpick: we should standardize on 12 hour since most of our customers are in the US/CA.
image

@ammario ammario added feature site Area: frontend dashboard labels Jun 8, 2022
greyscaled added a commit that referenced this issue Jun 9, 2022
This does not finish all tasks in #2175 but is one of the asks.

@johnstcn - you should do the same lowercasing of HH->hh in #2165
greyscaled added a commit that referenced this issue Jun 9, 2022
This does not finish all tasks in #2175 but is one of the asks.
@ketang
Copy link
Contributor

ketang commented Jun 9, 2022

Additional nitpick: we should standardize on 12 hour since most of our customers are in the US/CA.

Brace yourselves. Localization is coming.

I don't remember if I shared this, but I think we should have a way to pop up the dialog, and we should also have one click +30 minutes and +2 hours.

@ammario
Copy link
Member Author

ammario commented Jun 9, 2022

I don't remember if I shared this, but I think we should have a way to pop up the dialog, and we should also have one click +30 minutes and +2 hours.

If you could click a +1h button over and over again, that could be a cool way to add time.

Why do you think it should pop out in a new window? How does that help the user experience?

@ketang
Copy link
Contributor

ketang commented Jun 9, 2022

Yeah, same idea, but I chose +30 because I don't think people necessarily want the full hour. You could also argue with equal validity for +15 minutes and +1 hour.

Giving them the pop out gives them a way to specify some exact value instead of in 30 minute or 2 hour increments. Some people are fussy like that. Or they want to do an 24 hour extension without clicking 12 times. I don't think clicking 12 times is a big deal, but I guarantee people will want something that feels less mindless.

kylecarbs pushed a commit that referenced this issue Jun 10, 2022
This does not finish all tasks in #2175 but is one of the asks.
@ammario
Copy link
Member Author

ammario commented Jun 12, 2022

Yeah, same idea, but I chose +30 because I don't think people necessarily want the full hour. You could also argue with equal validity for +15 minutes and +1 hour.

Giving them the pop out gives them a way to specify some exact value instead of in 30 minute or 2 hour increments. Some people are fussy like that. Or they want to do an 24 hour extension without clicking 12 times. I don't think clicking 12 times is a big deal, but I guarantee people will want something that feels less mindless.

Since there will be a way to edit the wall-clock time of shutdown, there is a workaround to spam clicking the bump. In light of this, do you still think there should be a way to customize the bump amount in the UI?

@ketang
Copy link
Contributor

ketang commented Jun 13, 2022

in light of this, do you still think there should be a way to customize the bump amount in the UI?

Well, it's not so much customizing the increment as it is choosing one of a couple of present increment amounts. Although inevitably customers will want to be able to customize them I guess.

I think it's always better if you can do things in one click versus several. Whether it's better enough right now 🤷🏾‍♂️ . But eventually? I have no doubt.

@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard stale This issue is like stale bread.
Projects
None yet
Development

No branches or pull requests

3 participants