Skip to content

Add the ability to rename a workspace. Currently workspace must be deleted and a new one built to workaround this. #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #3042
sharkymark opened this issue Jun 8, 2022 · 8 comments

Comments

@sharkymark
Copy link
Contributor

sharkymark commented Jun 8, 2022

Problem Statement

Users must delete a workspace and build a new one if they decide they want to name a workspace something else. It's something that's expected and a really inconvenient and poor experience if you are not able to do this.

Definition of Done

Users can change the name of a workspace from UI or CLI if they decide they want to name their workspace something else.

@ketang
Copy link
Contributor

ketang commented Jun 9, 2022

Yep seems like table stakes.

@ammario
Copy link
Member

ammario commented Jun 9, 2022

I agree in principle. A problem is this means that persistent resource names (e.g the disk) cannot be named based on the workspace name. Perhaps that's an anti-pattern anyways.

@ketang
Copy link
Contributor

ketang commented Jun 9, 2022

Definitely an anti-pattern to link them that way. Naming them that way isn't terrible because we need to name them something, but we shouldn't attach semantics.

@ammario
Copy link
Member

ammario commented Jun 9, 2022

Definitely an anti-pattern to link them that way. Naming them that way isn't terrible because we need to name them something, but we shouldn't attach semantics.

In GCP at least, a disk's name is its ID. There is no way to rename a disk, except by light copying it via snapshot.

@ketang
Copy link
Contributor

ketang commented Jun 9, 2022

I think no matter what we're going to have to treat persistent-across-builds resources differently from throw-away-and-start-over resources. If that means different naming conventions, okay; it just goes on the pile of other things we'll need to manage differently.

@misskniss misskniss added needs grooming site Area: frontend dashboard api Area: HTTP API labels Jun 14, 2022
@tjcran
Copy link

tjcran commented Jun 22, 2022

@misskniss earmarking for next sprint

@tjcran tjcran changed the title Add the ability to rename a workspace. Seems like a shame you have to delete a workspace and rebuild to do that. Add the ability to rename a workspace. Currently workspace must be deleted and a new one built to workaround this. Jun 22, 2022
@ammario
Copy link
Member

ammario commented Jul 13, 2022

@tjcran I see this was marked for a sprint but what happened to this issue? It's a pretty big PITA to build up a workspace and then have to recreate it since the name is a bit off. Like, I don't want to actually keep my workspace named donkus...

@tjcran
Copy link

tjcran commented Jul 22, 2022

Duplicates #3000 closing this one in favor of that one which has more detail

@tjcran tjcran closed this as completed Jul 22, 2022
@mafredri mafredri removed their assignment Jul 22, 2022
@tjcran tjcran closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2022
@misskniss misskniss added invalid and removed feature site Area: frontend dashboard api Area: HTTP API labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants