Skip to content

Cache directory env variable for coder server is missing CODER_ prefix #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafredri opened this issue Jun 9, 2022 · 0 comments · Fixed by #2236
Closed

Cache directory env variable for coder server is missing CODER_ prefix #2199

mafredri opened this issue Jun 9, 2022 · 0 comments · Fixed by #2236
Assignees
@mafredri
Labels
api Area: HTTP API
Milestone
Community MVP

Comments

@mafredri
Copy link
Member

mafredri commented Jun 9, 2022

The cache directory env variable for coder server is missing the CODER_ prefix, it is called CACHE_DIRECTORY.

It should be CODER_CACHE_DIRECTORY for consistency and avoiding collisions.
@mafredri mafredri added bug api Area: HTTP API labels Jun 9, 2022
@mafredri mafredri mentioned this issue Jun 9, 2022
Closed
@mafredri mafredri self-assigned this Jun 10, 2022
mafredri added a commit that referenced this issue Jun 10, 2022
@mafredri
fix: Accept CODER_CACHE_DIRECTORY with CACHE_DIRECTORY fallback
40d00af 
Fixes #2199
@mafredri mafredri mentioned this issue Jun 10, 2022
Merged
mafredri added a commit that referenced this issue Jun 10, 2022
@mafredri
fix: Accept CODER_CACHE_DIRECTORY with CACHE_DIRECTORY fallback (#2236)
0260e39 
Fixes #2199
kylecarbs pushed a commit that referenced this issue Jun 10, 2022
@mafredri @kylecarbs
fix: Accept CODER_CACHE_DIRECTORY with CACHE_DIRECTORY fallback (#2236)
f6d6a10 
Fixes #2199
@misskniss misskniss added this to the Community MVP milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
api Area: HTTP API
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

fix: Accept CODER_CACHE_DIRECTORY with CACHE_DIRECTORY fallback coder/coder
2 participants
@mafredri @misskniss