Skip to content

coder bump should not stack bumps #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ammario opened this issue Jun 10, 2022 · 3 comments · Fixed by #2225 or #2230
Closed

coder bump should not stack bumps #2223

ammario opened this issue Jun 10, 2022 · 3 comments · Fixed by #2225 or #2230
Assignees
@ammario
Labels
api Area: HTTP API cli Area: CLI
Milestone
Community MVP

Comments

@ammario
Copy link
Member

ammario commented Jun 10, 2022

Screen Shot 2022-06-09 at 7 28 45 PM

  • The time by which we bump the workspace seems arbitrary? Why 90m? I'd rather be forced to specify the interval.
  • It's unclear what timezone the response is in. Also, I would rather a human readable format than RFC3339.
  • The bump should be fixed from the current time. If I bump repeatedly, it should always be now()+bump_dur. In the current form, it's difficult to script around bump. For example, I want my VS Code to call coder bump so my workspace stays online. I don't want to bump it into oblivion.
@ammario ammario self-assigned this Jun 10, 2022
@ammario
Copy link
Member Author

ammario commented Jun 10, 2022

@johnstcn what's the purpose of the extend API endpoint? Why not just PUT to /ttl?

@ammario
Copy link
Member Author

ammario commented Jun 10, 2022

I see the coder ttl command already works as expected. I will remove bump for now since I don't understand why we'd have two that do the same thing.

@ammario
Copy link
Member Author

ammario commented Jun 10, 2022

🤦 ignore my comments

ammario added a commit that referenced this issue Jun 10, 2022
@ammario
Make coder bump idempotent
96d187c 
Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
@ammario ammario mentioned this issue Jun 10, 2022
Merged
ammario added a commit that referenced this issue Jun 10, 2022
@ammario
Make coder bump idempotent (#2225)
0df75f9 
Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
@ammario ammario mentioned this issue Jun 10, 2022
Merged
ammario added a commit that referenced this issue Jun 10, 2022
@ammario
Make coder bump idempotent (#2230)
06021bd 
Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
@johnstcn johnstcn added cli Area: CLI api Area: HTTP API go labels Jun 10, 2022
kylecarbs pushed a commit that referenced this issue Jun 10, 2022
@ammario @kylecarbs
Make coder bump idempotent (#2225)
c3cbf1d 
Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
kylecarbs pushed a commit that referenced this issue Jun 10, 2022
@ammario @kylecarbs
Make coder bump idempotent (#2230)
a07cac9 
Resolves #2223

In addition to solving what's outlined in the issue,
I remove the client-side minute check because it had no
clear purpose when the API already returns an error.
@misskniss misskniss added this to the Community MVP milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ammario ammario

Labels
api Area: HTTP API cli Area: CLI
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

Make coder bump idempotent coder/coder
Make coder bump idempotent coder/coder
3 participants
@misskniss @johnstcn @ammario