Skip to content

Add support for emojis on templates #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ammario opened this issue Jun 10, 2022 · 19 comments · Fixed by #3601
Closed

Add support for emojis on templates #2262

ammario opened this issue Jun 10, 2022 · 19 comments · Fixed by #3601
Assignees
Labels
api Area: HTTP API site Area: frontend dashboard

Comments

@ammario
Copy link
Member

ammario commented Jun 10, 2022

Acceptance criteria

The template admin can configure emojis to accompany their template as a part of the main.tf.

Schema TBD.

image

Wouldn't this be beautiful?

(idea cred @kylecarbs)

@Explosion-Scratch
Copy link

Yea but with twemoji

@ammario
Copy link
Member Author

ammario commented Jun 10, 2022

@Explosion-Scratch nice idea! We're looking into it.

@sharkymark
Copy link
Contributor

👽

@Explosion-Scratch
Copy link

Explosion-Scratch commented Jun 11, 2022

@Explosion-Scratch nice idea! We're looking into it.

It wasn't my idea lol, it was @kylecarbs apparently

@ketang
Copy link
Contributor

ketang commented Jun 11, 2022

This is a silly thing that is also good to have.

We can do emoji in the names already, right? This would be a dedicated field for selecting one icon?

@ketang
Copy link
Contributor

ketang commented Jun 11, 2022

Seems like we should do this for users and workspaces too. None of this needs to happen immediately, but if easy...

@kylecarbs
Copy link
Member

I think we add an icon column that is a URI. For now it can be emoji://handwave, but eventually it can be file:/// etc.

@ketang
Copy link
Contributor

ketang commented Jun 11, 2022

Is emoji://handwave a real thing, or did you just invent it?

We don't want to allow file:// ever. If you're referring to an icon embedded in the archive, then we should go another way, for instance requiring them to have a file icon.json or something.

@Explosion-Scratch
Copy link

yeah, not exactly sure why to use emoji://, wouldn't just using a lookup table and allowing users to choose be fine? Emojis.json was made for this purpose (find on GH)

@ketang
Copy link
Contributor

ketang commented Jun 11, 2022

I actually thought emoji:// was pretty clever. We could forge a new path! Modifiers and combinations like skin tone would be interesting though.

@Explosion-Scratch
Copy link

I actually thought emoji:// was pretty clever. We could forge a new path! Modifiers and combinations like skin tone would be interesting though.

"forging a new path" was what you did in 1990. Now it'd just be inefficient, hard to implement, never used by anyone else, and probably insecure

@ammario
Copy link
Member Author

ammario commented Jun 12, 2022

This is a silly thing that is also good to have.

We can do emoji in the names already, right? This would be a dedicated field for selecting one icon?

The big problem with emojis in the name as opposed to a separate field is it makes it far harder to work with names in the CLI and programmatically.

@misskniss misskniss added the site Area: frontend dashboard label Jun 14, 2022
@tjcran tjcran mentioned this issue Jul 25, 2022
25 tasks
@misskniss
Copy link

@kylecarbs are you up for owning this?

@kylecarbs
Copy link
Member

Sure!

@kylecarbs kylecarbs self-assigned this Aug 2, 2022
@kylecarbs kylecarbs added the api Area: HTTP API label Aug 2, 2022
@ketang
Copy link
Contributor

ketang commented Aug 2, 2022

While emoji:// would be a neat gimmick, data URIs should be just fine:
data:text/plain;charset=utf-8;base64,8J+MrvCfpog=

Should be read as

🌮🦈

@ammario
Copy link
Member Author

ammario commented Aug 2, 2022

Can we do #2221 instead of this? #2221 would still allow emojis, but the more reasonable use case is using OS/Cloud/Software logos as described in that issue.

@kylecarbs
Copy link
Member

Makes sense to me. I'll swap it out.

@kylecarbs kylecarbs closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2022
@sharkymark
Copy link
Contributor

😞

@BrunoQuaresma
Copy link
Collaborator

Reopening this, since icons can support emojis if users pass the image path, we want to provide a better experience by adding an emoji picker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Area: HTTP API site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants