Skip to content

Panics in HTTP handlers are not logged #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
coadler opened this issue Jun 15, 2022 · 2 comments · Fixed by #3687
Closed

Panics in HTTP handlers are not logged #2338

coadler opened this issue Jun 15, 2022 · 2 comments · Fixed by #3687
Assignees
@sreya
Labels
api Area: HTTP API
Milestone
EE

Comments

@coadler
Copy link
Contributor

coadler commented Jun 15, 2022

They transparently return a 502 with no error message and no logs on the server. This makes panics impossible to debug.
@coadler coadler added bug api Area: HTTP API labels Jun 15, 2022
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Aug 24, 2022
@kylecarbs
Copy link
Member

Ouchie. I'm adding this to EE, as any production software would do this.

@kylecarbs kylecarbs removed the stale This issue is like stale bread. label Aug 24, 2022
@kylecarbs kylecarbs added this to the EE milestone Aug 24, 2022
@sreya sreya self-assigned this Aug 24, 2022
@sreya sreya mentioned this issue Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreya sreya

Labels
api Area: HTTP API
Projects
None yet
Milestone
EE
Development

Successfully merging a pull request may close this issue.

feat: add panic recovery middleware coder/coder
3 participants
@sreya @coadler @kylecarbs