Skip to content

Bug: new tab click idioms don't work on workspace, workspaces, and templates page page #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ketang opened this issue Jun 20, 2022 · 0 comments · Fixed by #2532
Closed

Bug: new tab click idioms don't work on workspace, workspaces, and templates page page #2525

ketang opened this issue Jun 20, 2022 · 0 comments · Fixed by #2532
Assignees
@kylecarbs

Comments

@ketang
Copy link
Contributor

ketang commented Jun 20, 2022

When I <middle>-click, <ctrl>-click, or <cmd>-click on one of these rows, I should get the destination page in a new tab
image

Currently <middle>-click does nothing and <ctrl>-click acts as a normal click. I haven't tested <cmd>-click, but I assume it's the same.
@kylecarbs kylecarbs self-assigned this Jun 20, 2022
kylecarbs added a commit that referenced this issue Jun 20, 2022
@kylecarbs
fix: Wrap TableCell with Link for native browser routing
a6b0a77 
Tables were previously using an onClick handler which replicated some
Link behavior, but not natively through the browser.

Fixes #2525.
@kylecarbs kylecarbs mentioned this issue Jun 20, 2022
Merged
kylecarbs added a commit that referenced this issue Jun 21, 2022
@kylecarbs
fix: Wrap TableCell with Link for native browser routing
9c26023 
Tables were previously using an onClick handler which replicated some
Link behavior, but not natively through the browser.

Fixes #2525.
kylecarbs added a commit that referenced this issue Jun 21, 2022
@kylecarbs
fix: Wrap TableCell with Link for native browser routing
2956e06 
Tables were previously using an onClick handler which replicated some
Link behavior, but not natively through the browser.

Fixes #2525.
kylecarbs added a commit that referenced this issue Jun 21, 2022
@kylecarbs
fix: Wrap TableCell with Link for native browser routing (#2532)
a48a838 
Tables were previously using an onClick handler which replicated some
Link behavior, but not natively through the browser.

Fixes #2525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Wrap TableCell with Link for native browser routing coder/coder
2 participants
@ketang @kylecarbs