Skip to content

Bug: using wrong coder binary for ProxyCommand in config-ssh #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ketang opened this issue Jun 20, 2022 · 1 comment · Fixed by #2647
Closed

Bug: using wrong coder binary for ProxyCommand in config-ssh #2528

ketang opened this issue Jun 20, 2022 · 1 comment · Fixed by #2647
Assignees

Comments

@ketang
Copy link
Contributor

ketang commented Jun 20, 2022

Had a run-in with this one:

ketan@Spindrift:/tmp/coder2$ ./coder config-ssh
The current executable path does not match the executable path found in $PATH.
  | This may cause issues connecting to your workspace via SSH.
  |     Current executable path: "/tmp/coder2/coder"
  |     Executable path in $PATH: "/home/ketan/bin/coder"

To fix it I had to edit my .ssh/config to use the former path as the latter was coder v1. I think it should either always use the current executable or prompt the user to choose. In this case config-ssh sort of knowingly did the wrong thing, and I think our typical user won't necessarily know how to deal with it.

A cleverer elaboration would be to inspect the various coder binaries found and prune the set to the ones that are v2-compatible.

@sreya sreya self-assigned this Jun 23, 2022
@sreya
Copy link
Collaborator

sreya commented Jun 24, 2022

Yeah I'm pretty sure this has to be a bug. I'm going to go with the simplest fix which is to simply use the absolute path of the coder executable you used to run ./coder config-ssh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants