Skip to content

rename coder config-ssh --diff to coder config-ssh --dry-run #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ketang opened this issue Jun 20, 2022 · 2 comments · Fixed by #2575
Closed

rename coder config-ssh --diff to coder config-ssh --dry-run #2530

ketang opened this issue Jun 20, 2022 · 2 comments · Fixed by #2575
Assignees
@mafredri

Comments

@ketang
Copy link
Contributor

ketang commented Jun 20, 2022

Rename coder config-ssh --diff to coder config-ssh --dry-run. I think, though I could be wrong, that --dry-run is more common. @mafredri am I perhaps misinformed?
@mafredri
Copy link
Member

Sure, --dry-run sounds great! Shall we do -n for short-hand? (As in no-op, it's pretty common and this combo is used by e.g. rsync and zfs off the top of my head.)

@ketang
Copy link
Contributor Author

ketang commented Jun 20, 2022

Sounds good to me. I don't have a specific opinion; I just want to be conventional.

@mafredri mafredri self-assigned this Jun 22, 2022
mafredri added a commit that referenced this issue Jun 22, 2022
@mafredri
feat: Rename config-ssh --diff to --dry-run
8060b66 
Since the intent between diff and dry-run are different, this change
allows for interactive prompts to be shown during `--dry-run`,
previously prompts were disabled. Dry-run can also be chanied with
`--yes` and `--use-previous-options` for non-interactive modes.

Dry-run is like a normal run with changes replaced by diff.

Fixes #2530
@mafredri mafredri mentioned this issue Jun 22, 2022
Merged
mafredri added a commit that referenced this issue Jun 22, 2022
@mafredri @johnstcn
feat: Rename config-ssh --diff to --dry-run (#2575)
11c47e0 
* feat: Rename config-ssh `--diff` to `--dry-run`

Since the intent between diff and dry-run are different, this change
allows for interactive prompts to be shown during `--dry-run`,
previously prompts were disabled. Dry-run can also be chanied with
`--yes` and `--use-previous-options` for non-interactive modes.

Dry-run is like a normal run with changes replaced by diff.

Fixes #2530

Co-authored-by: Cian Johnston <cian@coder.com>
@npease18 npease18 mentioned this issue Jul 11, 2022
Merged
kylecarbs pushed a commit that referenced this issue Jul 11, 2022
@npease18
Update docs in reference to command change in #2530 (#2902)
74d484e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Rename config-ssh --diff to --dry-run coder/coder
3 participants
@ketang @mafredri @maryna-hankevich