-
Notifications
You must be signed in to change notification settings - Fork 881
Parameters design and UX flow for editing/creating parameters associated with template versions/workspaces #2719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Emyrk and I discussed how the behavior is slightly different now as template-wide (e.g coder/coderd/parameter/compute.go Lines 183 to 187 in f7ea016
|
@Emyrk do you want to own this? I feel like you're passionate about it. |
@kylecarbs Yes. With @deansheather 's latest mini RFC, I want that "approved" first from a terraform design. Then we can determine the backend design imo. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
Closing since #4311 reworks this |
Problem
Currently parameters have some ambiguity around how they are supposed to behave.
workspace > version > template
.sensitive
field of the terraform variable.template
is unused in the codebase.import_job
is associated with a job, but should probably be tied to a template_versionCLI prompts for new params and handles deleted params in a new version, but the UI does not. The decision tree for how to handle param prompting is complex.
CLI param handling code is unique for template flow and workspace flow. We should unify this logic.
Who can read param values? Secret values?
How to inherit params from previous version/workspace build?
Design
A design document for params should be created on how params should function. From the terraform value, to the database store, to how to fill in param values. The terraform file should be able to indicate where values should be prompted (at the version create or workspace create)
A good parameter viewer to indicate which param values are associated with a version/workspace and where they came from. Maybe an editor to change these values??
Should we keep a param hierarchy? Or should some values be required to be set at a certain scope, and disallow workspaces from setting them?
Prompt for missing params does not cleanup broken template versions.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: