Skip to content

Workspace schedule bumpers are broken #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3042
, #3182
...
ammario opened this issue Jun 30, 2022 · 5 comments · Fixed by #3532
Closed
Tracked by #3042
, #3182
...

Workspace schedule bumpers are broken #2764

ammario opened this issue Jun 30, 2022 · 5 comments · Fixed by #3532
Assignees
@johnstcn
Labels
site Area: frontend dashboard

Comments

@ammario
Copy link
Member

ammario commented Jun 30, 2022 •
edited by tjcran
Loading

Problem

Bumpers in the workspace schedule are broken

Steps to reproduce

  1. Press a + or - button and observe error

Screen Shot 2022-06-30 at 2 41 58 PM

Screen Shot 2022-06-30 at 2 42 41 PM

Definition of Done

A user should be able to modify the shutdown using the bumpers + or -

Perhaps it is following the template policy correctly, but the error makes it appear broken.
@ammario ammario added the bug label Jun 30, 2022
@kylecarbs kylecarbs mentioned this issue Jul 19, 2022
Closed
20 tasks
@spikecurtis spikecurtis added the site Area: frontend dashboard label Jul 21, 2022
@misskniss
Copy link

The current value set on the lease could be great than that on the template - we may not be checking the template? (@johnstcn ). Potential: Grey out a bumper if it is not possible any more?

@misskniss
Copy link

related: #2942

@presleyp
Copy link
Contributor

Validation on the FE (disabling the buttons) is the best solution here but I will surface the backend error in #3097 as well (it'll only come through if FE validation fails for some reason).

@tjcran tjcran mentioned this issue Jul 29, 2022
Closed
25 tasks
@ammario
Copy link
Member Author

ammario commented Aug 18, 2022

This was fixed at some point.

@ammario ammario closed this as completed Aug 18, 2022
@johnstcn johnstcn reopened this Aug 18, 2022
@johnstcn
Copy link
Member

@ammario there's still an issue with the ➕ bumper and workspace templates with max TTL < 24h. #3532 should fix this when it's merged.

@johnstcn johnstcn mentioned this issue Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ui: workspace bumpers now honour template max_ttl coder/coder
6 participants
@presleyp @misskniss @johnstcn @spikecurtis @ammario @OlgaKhmelevskaya