Skip to content

coder templates delete does not confirm #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ketang opened this issue Jul 4, 2022 · 0 comments · Fixed by #2866
Closed

coder templates delete does not confirm #2830

ketang opened this issue Jul 4, 2022 · 0 comments · Fixed by #2866

Comments

@ketang
Copy link
Contributor

ketang commented Jul 4, 2022

It just deletes the files! That's dangerous!
ketang added a commit that referenced this issue Jul 8, 2022
@ketang
prompt for confirmation before deleting templates (#2830)
5b51ea3
@ketang ketang mentioned this issue Jul 8, 2022
Merged
ketang added a commit that referenced this issue Jul 11, 2022
@ketang
fix: confirm when deleting template (#2866)
536c77a 
* prompt for confirmation before deleting templates (#2830)

* populate templateNames from the interactive picker too

* allow skipping delete confirmation prompt with --yes flag

* eliminate unnecessary newline

* test both confirmation of delete and `--yes` with no confirmation

* fix failing test that needed --yes

* remove unnecessary empty line the linter disliked

* make the tests correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: confirm when deleting template coder/coder
2 participants
@ketang @maryna-hankevich