Redirect to login when PWA/Web-App is opened and cookie is expired #2884
Assignees
Comments
|
Ahh, good issue! We'll have to adjust our middleware handling to do an auth redirection instead. |
|
@AbhineetJain might be related to PWA work you're looking at |
kylecarbs
added a commit
that referenced
this issue
Jul 11, 2022
kylecarbs
added a commit
that referenced
this issue
Jul 11, 2022
kylecarbs
added a commit
that referenced
this issue
Jul 11, 2022
|
Thanks @kylecarbs for adding this so fast your are awesome. |
|
@kylecarbs I think there might be a bug. So my setup is the following. The workspace is running and I am logged out. I then open the PWA and get redirect to the login page, when I then login get a "code-server is offline!" page, and this is not the case. When I press Strg+R to reload the page code-server loads correctly. Edit: I created a new issue for this. |
|
Ahh I know the issue. We cannot route via the frontend to these pages like
normal. I’ll make a PR to fix it.
…On Mon, Jul 11, 2022 at 2:48 PM Timo ***@***.***> wrote:
@kylecarbs <https://github.com/kylecarbs> I think there might be a bug.
So my setup is the following. The workspace is running and I am logged out.
I then open the PWA and get redirect to the login page, when I then login
get a "code-server is offline!" page, and this is not the case. When I
press Strg+R to reload the page code-server loads correctly.
—
Reply to this email directly, view it on GitHub
<#2884 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWKZRD572YHQUPUXIGOD4TVTR3CNANCNFSM53G7F6BA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Situation
Currently when a user opens a PWA e.g. code-server a message appears
{"message":"Cookie \"session_token\" or query parameter must be provided."}stating that the cookie is expired. The user then has to open a new chrome window open the coder url login and refresh the pwa. This is not ideal of a workflow.Desired Solution
The PWA page should just redirect to the login so that the user can authenticate and then load the application e.g. code-server.
How to reproduce
The text was updated successfully, but these errors were encountered: