-
Notifications
You must be signed in to change notification settings - Fork 875
RFC: Template owners #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think we should just do standard RBAC type stuff here. We could also make this simpler and rely on version control capabilities to deal with permissions and mutexing with the to-be-built VCS integration add-on. Maybe we don't actually need to do anything natively. |
RBAC with few owners serves as a basic mutex. I'm not proposing anything additional. And yes, a template backed by VCS has a lot of nice properties. |
This could be entirely replaced by #2958 I think. |
Replacing this with the other issue means that anyone who doesn't want VCS-backed templates (or uses a VCS we don't support) will have no ability to manage multiple users' access. That's probably okay, but I wouldn't want to rely too confidently on that assumption in our implementation or brains. |
We have never had a customer that doesn't use git repos with support for SSH cloning, so I don't think we need to worry about unsupported VCS. |
So, there are a lot admins on our dev deployment and a lot of people that can make template changes.
None of our templates are updated automatically in CI—not even the primary dogfood template called "coder". This was an intentional decision by @kylecarbs so we can dogfood in a manner similar to our users.
The
coder
template can be pulled down by any admin and edited by anyone. There is no built in change management, so it's very easy for two people to run edits on the same template simultaneously and overwrite each other's work. Furthermore, the product doesn't make who you seek template support from clear. There is the "created by" but that is an unchangeable value and will almost certainly fall out of date. In dogfood, I'd bet many don't know that they should ping Kyle and not Dean.This is especially top of mind for me as I work on a new dogfood template. I don't want anyone other than me editing the template and I want everyone contacting me if they have issues.
Proposal
The owners function as both a mutex and support clarity.
The text was updated successfully, but these errors were encountered: