-
Notifications
You must be signed in to change notification settings - Fork 875
RFC: Git-backed templates #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Our VCS support should allow multiple URLs for the same template and create a union of all files. That allows them to have separate governance for individual subsets of files, for instance to more tightly limit who has access to sensitive data contained in one file. |
So, our whole model becomes more complex when we assume that sensitive data will be in both the templates and the provisioner environment. See our recommended approach to secrets here. Most git providers support CODEOWNERS so they can finely control edit access in the repo without us adding an additional feature. |
Yeah. I'm not expressing a preference. I'm just predicting what customers will want. Also, there are different kinds of sensitive data that may appear in templates. It's not just authentication secrets. |
Especially could be a concern interfacing with legacy systems that aren't compatible with more modern auth*. |
I really like the idea of git-backed templates since I think that's the way that most people that are seriously using the product are going to want to source-control their workspace configuration. Some thoughts on how this would be implemented:
It's worth mentioning that people can use |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
See problem statement in #2950
If I could set a template as backed by a git ref, change management is dead simple. Iteration shouldn't suffer as
template update
is replaced bygit push
.CI automation (e.g pushing a Docker image with each template) also becomes simpler.
We should do the "Open in Coder" button alongside this as well. Keep in mind that this button should support specifying a path within the repository, as multiple templates can coexist in one repo.
The text was updated successfully, but these errors were encountered: