Skip to content

Make workspace "Update" button stand alone #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #3042
ketang opened this issue Jul 18, 2022 · 10 comments · Fixed by #3115
Closed
Tracked by #3042

Make workspace "Update" button stand alone #3024

ketang opened this issue Jul 18, 2022 · 10 comments · Fixed by #3115
Assignees
Labels
site Area: frontend dashboard

Comments

@ketang
Copy link
Contributor

ketang commented Jul 18, 2022

A recent change (#2748) combined the different workspace buttons to free up some space. This is a good change, but there was a little collateral damage. I think the "Update" button shouldn't be grouped; if the template is out of date, it should always be top level instead of in the collapsed array. OR "Update" could be the first button with "Start" being in the drop-down.

Definition of Done:
Update call to action should be more prominent.

image

AC as per below discussion:

  • keep Update in button dropdown
  • make it the primary CTA when an update is available
  • add an 'Outdated' tooltip (similar to the one in the workspaces table) when an update is available
@BrunoQuaresma
Copy link
Collaborator

What do you think about removing the "Update" button and showing the "Outdated" tooltip as we do for the workspace table row?

Screen Shot 2022-07-18 at 16 29 27

Screen Shot 2022-07-18 at 16 29 18

@ketang
Copy link
Contributor Author

ketang commented Jul 18, 2022

Perhaps we do both the tooltip/dialog and the update button? I think we want to strongly encourage users to update their workspaces if they're behind, and putting an extra step in front of "Start" helps with that. Also I assume the "Update" button change is trivial, while the other is a bit more effort. Maybe just do the button now and save the tooltip etc. for a couple of sprints from now?

@BrunoQuaresma
Copy link
Collaborator

@Kira-Pilot I think you would be the best person to work on this. What do you think?

@Kira-Pilot
Copy link
Member

@BrunoQuaresma sounds good to me!

@BrunoQuaresma BrunoQuaresma added the site Area: frontend dashboard label Jul 19, 2022
@kylecarbs kylecarbs mentioned this issue Jul 19, 2022
20 tasks
@ketang
Copy link
Contributor Author

ketang commented Jul 19, 2022

In grooming this morning, @presleyp suggested we remove the Update button from the button stack entirely. Its display would still be conditional on the template freshness status. That seems like it solves the problem also.

@presleyp
Copy link
Contributor

I think that was @Kira-Pilot ?

@ketang
Copy link
Contributor Author

ketang commented Jul 19, 2022

🤦🏾‍♂️

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jul 20, 2022

@ketang @BrunoQuaresma are we okay with leaving Update in the dropdown, and making it the primary CTA when an update is available? I know I argued against this the other day in grooming but I've since reconsidered 😅
LMK if you object; otherwise I'll move forward with that proposal.
I can add the tooltip, too, if we want.

@ketang
Copy link
Contributor Author

ketang commented Jul 20, 2022

Both options achieve my goal of making "Update" highly visible, so I'm satisfied either way.

@BrunoQuaresma
Copy link
Collaborator

I'm good as well!

Kira-Pilot added a commit that referenced this issue Jul 22, 2022
* feat: give update button primary focus when applicable

resolves #3024

* added update tooltip

* cleanup

* prettier

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants