-
Notifications
You must be signed in to change notification settings - Fork 881
Make workspace "Update" button stand alone #3024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Perhaps we do both the tooltip/dialog and the update button? I think we want to strongly encourage users to update their workspaces if they're behind, and putting an extra step in front of "Start" helps with that. Also I assume the "Update" button change is trivial, while the other is a bit more effort. Maybe just do the button now and save the tooltip etc. for a couple of sprints from now? |
@Kira-Pilot I think you would be the best person to work on this. What do you think? |
@BrunoQuaresma sounds good to me! |
In grooming this morning, @presleyp suggested we remove the Update button from the button stack entirely. Its display would still be conditional on the template freshness status. That seems like it solves the problem also. |
I think that was @Kira-Pilot ? |
🤦🏾♂️ |
@ketang @BrunoQuaresma are we okay with leaving |
Both options achieve my goal of making "Update" highly visible, so I'm satisfied either way. |
I'm good as well! |
* feat: give update button primary focus when applicable resolves #3024 * added update tooltip * cleanup * prettier * PR feedback
A recent change (#2748) combined the different workspace buttons to free up some space. This is a good change, but there was a little collateral damage. I think the "Update" button shouldn't be grouped; if the template is out of date, it should always be top level instead of in the collapsed array. OR "Update" could be the first button with "Start" being in the drop-down.
Definition of Done:
Update call to action should be more prominent.
AC as per below discussion:
Update
in button dropdownThe text was updated successfully, but these errors were encountered: