Skip to content

Allow adding specific users to specific templates #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ammario opened this issue Jul 21, 2022 · 8 comments · Fixed by #4235
Closed

Allow adding specific users to specific templates #3102

ammario opened this issue Jul 21, 2022 · 8 comments · Fixed by #4235
Assignees
Labels
enterprise Enterprise-license / premium functionality
Milestone

Comments

@ammario
Copy link
Member

ammario commented Jul 21, 2022

As a template admin, I only want certain users to access specific templates. For example, I have experimental templates I want to use myself. I also have contractors that should only use one template for security reasons.

The RBAC system has to be built with groups in mind since this feature is for large deployments. I suggest we implement #2791 simultaneously.

Related #2950

@sreya
Copy link
Collaborator

sreya commented Jul 21, 2022

@ammario isn't this sort of access control better suited for RBAC than template metadata?

@ammario
Copy link
Member Author

ammario commented Jul 21, 2022

Well this is RBAC too :)

@ammario
Copy link
Member Author

ammario commented Jul 21, 2022

I edited the original post to reflect the points you brought up in Discord about how doing this in the UI/API makes more sense than with config.

@ammario ammario changed the title all my users can use all my templates Every user can use every template Aug 18, 2022
@ammario ammario added the enterprise Enterprise-license / premium functionality label Aug 18, 2022
@ammario ammario added this to the EE milestone Aug 22, 2022
@Emyrk
Copy link
Member

Emyrk commented Aug 23, 2022

Is this different groups than orgs? The current templates are scoped to an organization, and all users on the product are in the first organization.

Is the suggestion to support groups within orgs? At present the RBAC system only supports "organization" grouping of resources.

@ammario
Copy link
Member Author

ammario commented Aug 23, 2022

Is this different groups than orgs? The current templates are scoped to an organization, and all users on the product are in the first organization.

Is the suggestion to support groups within orgs? At present the RBAC system only supports "organization" grouping of resources.

I'm using groups and orgs interchangeably. We should probably revisit the terminology with this fresh start.

@Emyrk
Copy link
Member

Emyrk commented Aug 24, 2022

Just checking there was not a suggestion to create a second layer of grouping. 1 level of grouping is good 👍.

Terminology wise, happy to change. The code is all saying "organization_id" and already supports this. We just don't expose the creation of multiple orgs atm. Unsure how the cli and ui handle switching orgs atm.

@kylecarbs kylecarbs changed the title Every user can use every template Allow adding specific users to specific templates Aug 24, 2022
@bpmct
Copy link
Member

bpmct commented Sep 1, 2022

Another prospect has requested this feature: giving specific groups of users access to specific templates.

@sreya sreya self-assigned this Sep 8, 2022
@bpmct bpmct changed the title Allow adding specific users to specific templates Template permissions: Allow adding specific users to specific templates Sep 9, 2022
@kylecarbs kylecarbs changed the title Template permissions: Allow adding specific users to specific templates Allow adding specific users to specific templates Sep 23, 2022
@sreya
Copy link
Collaborator

sreya commented Oct 12, 2022

closed by #4235

@sreya sreya closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise Enterprise-license / premium functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants