Skip to content

Fix issues reported by goleak in cli package tests and then enable goleak #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafredri opened this issue Jul 26, 2022 · 1 comment · Fixed by #3370
Closed

Fix issues reported by goleak in cli package tests and then enable goleak #3221

mafredri opened this issue Jul 26, 2022 · 1 comment · Fixed by #3370
Assignees
@mafredri
Labels
api Area: HTTP API

Comments

@mafredri
Copy link
Member

As per the title, we have not had goleak enabled for CLI tests. We should turn it on and work through each test that is causing leaks to be reported with the final goal of permanently enabling goleak.
@mafredri mafredri self-assigned this Jul 26, 2022
@mafredri mafredri added bug api Area: HTTP API labels Jul 26, 2022
mafredri added a commit that referenced this issue Jul 27, 2022
@mafredri
fix: Close notifier Poll goroutine on stop
3f9f183 
Fix towards #3221.
@mafredri mafredri mentioned this issue Jul 27, 2022
Merged
mafredri added a commit that referenced this issue Jul 27, 2022
@mafredri
fix: Fix goleak in cli TestSSH tests
eeb74e1 
Commands are now also run with contexts that time out.

Work towards #3221.
@mafredri mafredri mentioned this issue Jul 27, 2022
Merged
mafredri added a commit that referenced this issue Jul 27, 2022
@mafredri
fix: Close notifier Poll goroutine on stop (#3252)
a0320f4 
Fix towards #3221.
mafredri added a commit that referenced this issue Jul 27, 2022
@mafredri
fix: Fix goleak in cli TestSSH tests (#3253)
46564fb 
Commands are now also run with contexts that time out.

Work towards #3221.
@mafredri
Copy link
Member Author

mafredri commented Jul 28, 2022 •
edited
Loading

Related: pion/udp#73, hashicorp/hc-install#68

mafredri added a commit that referenced this issue Aug 2, 2022
@mafredri
fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds
ca14871 
We could turn it into a practice to wrap `cmd.Context()` so that we have
more fine-grained control of cancellation. Sometimes in tests we may be
running commands with a context that is never canceled.

Related to #3221
@mafredri mafredri mentioned this issue Aug 2, 2022
Merged
mafredri added a commit that referenced this issue Aug 2, 2022
@mafredri
fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds (#…
83c63d4 
…3354)

* fix: Improve shutdown procedure of ssh, portforward, wgtunnel cmds

We could turn it into a practice to wrap `cmd.Context()` so that we have
more fine-grained control of cancellation. Sometimes in tests we may be
running commands with a context that is never canceled.

Related to #3221

* fix: Set ssh session stderr to stderr
This was referenced Aug 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
api Area: HTTP API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Enable goleak for cli tests coder/coder
1 participant
@mafredri