Skip to content

Add react-i18next to the FE #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
Kira-Pilot opened this issue Aug 12, 2022 · 0 comments · Fixed by #3682
Closed
4 tasks done

Add react-i18next to the FE #3486

Kira-Pilot opened this issue Aug 12, 2022 · 0 comments · Fixed by #3682
Labels
site Area: frontend dashboard

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Aug 12, 2022

User statement

As a future user, I would (maybe) like to enjoy a translated application.

As a current coder, I want to be able to store translation strings in a robust manner.

Background
Currently, all of our translation strings are stored in custom objects colocated with a component. As discussed in FE variety, we are pivoting to use a library to handle translations. There are numerous reasons for this (see the Notion doc) but some of big ones are:

Right now, sometimes we break up strings in ways that aren’t actually conducive to future translation; a library would help with that
Currently, if a developer refactors up a Language object, it is unclear which strings are not in use. Switching to a library will help us avoid stale strings
Sometimes we store business state in our Language objects. This is an anti-pattern that a library would help us avoid.

Definition of Done

  • Add react-i18next to our Front End.
  • Add at least one translation file as proof-of-concept so that it's easy for others to get started with translations when they make new PRs or refactor old code.
  • There is no need to migrate all Language blocks over right now. This can be an incremental change that we make going forward.
  • Ensure all tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant