Skip to content

Add option message prop to FullScreenLoader #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Aug 18, 2022 · 3 comments
Closed

Add option message prop to FullScreenLoader #3554

johnstcn opened this issue Aug 18, 2022 · 3 comments
Labels
site Area: frontend dashboard

Comments

@johnstcn
Copy link
Member

ref: #3532 (comment)_

Problem:

We currently don't have any way to show specific loading steps in FullScreenLoader (e.g. "Reticulating Splines").

Solution

Add a prop to FullScreenLoader to allow setting an optional message. The default will be something like "Loading..."
@johnstcn johnstcn added site Area: frontend dashboard enhancement labels Aug 18, 2022
@kylecarbs kylecarbs changed the title feat: ui: add prop to FullScreenLoader Add option message prop to FullScreenLoader Aug 24, 2022
@BrunoQuaresma
Copy link
Collaborator

@johnstcn where in the current UI do you think this would be well used?

@johnstcn
Copy link
Member Author

johnstcn commented Sep 8, 2022

@johnstcn where in the current UI do you think this would be well used?

Originally I was thinking it would be good to show "Loading Workspace..." and then "Loading Template..." in <WorkspacePage>, but it could be good to show any time we are asynchronously loading a resource.

@BrunoQuaresma
Copy link
Collaborator

Ahh, I see. In this case Idk if let the user know what the app is loading could be helpful. I'm closing this for now until we receive user feedback related to this.

@johnstcn johnstcn reopened this Sep 8, 2022
@johnstcn johnstcn closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BrunoQuaresma @johnstcn @kylecarbs