Skip to content

Emojis with multiple unicode bytes aren't bundled #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericpaulsen opened this issue Aug 25, 2022 · 1 comment · Fixed by #4682
Closed

Emojis with multiple unicode bytes aren't bundled #3689

ericpaulsen opened this issue Aug 25, 2022 · 1 comment · Fixed by #4682
Labels
site Area: frontend dashboard

Comments

@ericpaulsen
Copy link
Member

ericpaulsen commented Aug 25, 2022 •
edited by kylecarbs
Loading

👋 @kylecarbs

For some reason, the 🖥️ emoji isn't bundled in our emoji folder. As you can see from the links below, a normal emoji can be found at the route, but the desktop computer cannot!

😃 https://dev.coder.com/emojis/1f606.png
🖥️ https://dev.coder.com/emojis/1f5a5-fe0f.png

after updating to 0.8.6, I edited one of my pre-existing aws-ec2-code-server template with an emoji. below is the resulting UI:

Screen Shot 2022-08-24 at 10 51 59 PM

template settings:

Screen Shot 2022-08-24 at 10 28 12 PM

reproduced on Safari, Chrome, & Firefox.
@kylecarbs kylecarbs changed the title Template emoji not rendering The 🖥️ emoji isn't bundled Aug 25, 2022
@kylecarbs kylecarbs added site Area: frontend dashboard simple labels Aug 25, 2022
@kylecarbs
Copy link
Member

Neither is ☁️!

@kylecarbs kylecarbs mentioned this issue Aug 30, 2022
Closed
@kylecarbs kylecarbs changed the title The 🖥️ emoji isn't bundled Emojis with multiple unicode bytes aren't bundled Aug 30, 2022
kylecarbs added a commit that referenced this issue Oct 21, 2022
@kylecarbs
fix: Remove extra unicode char from some emojis
ef01adf 
Fixes #3689.
@kylecarbs kylecarbs mentioned this issue Oct 21, 2022
Merged
kylecarbs added a commit that referenced this issue Oct 21, 2022
@kylecarbs
fix: Remove extra unicode char from some emojis
bd4a4e2 
Fixes #3689.
kylecarbs added a commit that referenced this issue Oct 21, 2022
@kylecarbs
fix: Remove extra unicode char from some emojis (#4682)
4d8cc75 
Fixes #3689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove extra unicode char from some emojis coder/coder
2 participants
@kylecarbs @ericpaulsen