Skip to content

🎨 Bug: Can't delete an emoji for a template #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sharkymark opened this issue Aug 30, 2022 · 2 comments · Fixed by #3760
Closed

🎨 Bug: Can't delete an emoji for a template #3756

sharkymark opened this issue Aug 30, 2022 · 2 comments · Fixed by #3760
Assignees
@BrunoQuaresma

Comments

@sharkymark
Copy link
Contributor

Version: v0.8.9+6285d65

When I attempt to remove an emoji from a template and click save, it still retains the emoji. So now I am stuck with a lame emoji.
@BrunoQuaresma
Copy link
Collaborator

This is an interesting one. When the API receives an empty string or an empty value in the PATCH request, the API ignores it and uses the current value. I'm not sure if in Golang we can check if a value exists or not in the request body and/or if it is null. In JS we have undefined and null but Idk if Golang has something similar.

@BrunoQuaresma BrunoQuaresma self-assigned this Aug 30, 2022
@BrunoQuaresma
Copy link
Collaborator

After chatting with @kylecarbs, I'm going to change the API to not assign the current value if the request passes an empty string.

@BrunoQuaresma BrunoQuaresma mentioned this issue Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Accepts empty string for the icon prop to remove it coder/coder
2 participants
@sharkymark @BrunoQuaresma