Skip to content

Template input when creating a workspace ignores defaults if changed and empty #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kotx opened this issue Aug 31, 2022 · 2 comments · Fixed by #3902
Closed

Template input when creating a workspace ignores defaults if changed and empty #3771

kotx opened this issue Aug 31, 2022 · 2 comments · Fixed by #3902
Assignees
@BrunoQuaresma
Labels
site Area: frontend dashboard

Comments

@kotx
Copy link

kotx commented Aug 31, 2022

If I type in a template variable input field when creating a workspace, and then delete what I typed, the input turns into "" instead of the default (when there is one).
@kylecarbs kylecarbs added bug site Area: frontend dashboard labels Aug 31, 2022
@kylecarbs kylecarbs changed the title Template variable input ignores defaults if changed and empty Template input when creating a workspace ignores defaults if changed and empty Aug 31, 2022
@BrunoQuaresma
Copy link
Collaborator

I see. I think we can:

  • Use the default value as an input placeholder. So if the field is empty, the user will see the default value there.
  • Before sending it to the server, if the value is an empty string, use the default value.

@kotx do you think this sounds good?

@kotx
Copy link
Author

kotx commented Sep 2, 2022

Yup, sounds good!

@BrunoQuaresma BrunoQuaresma self-assigned this Sep 6, 2022
@BrunoQuaresma BrunoQuaresma mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Skip empty values so Terraform can use the default value coder/coder
3 participants
@BrunoQuaresma @kylecarbs @kotx