Skip to content

cli: do not show install script on Windows client #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #5051
matifali opened this issue Sep 27, 2022 · 3 comments · Fixed by #5418
Closed
Tracked by #5051

cli: do not show install script on Windows client #4226

matifali opened this issue Sep 27, 2022 · 3 comments · Fixed by #5418

Comments

@matifali
Copy link
Member

While running coder on the Windows client. I get

PS C:\Users\matif> ssh coder.aihwkit
version mismatch: client v0.8.15+9e9a9e0, server v0.9.1+27c8345
download the server version with: 'curl -L https://coder.com/install.sh | sh -s -- --version 0.9.1'

The installation script does not work on windows, so this message should not be shown.
@kylecarbs
Copy link
Member

Good catch!

kylecarbs added a commit that referenced this issue Oct 21, 2022
@kylecarbs
fix: Remove install script warning on Windows
98b2b5a 
Fixes #4226.
@matifali
Copy link
Member Author

matifali commented Nov 8, 2022

Still getting this, @kylecarbs

PowerShell 7.2.7
Copyright (c) Microsoft Corporation.

https://aka.ms/powershell
Type 'help' to get help.

version mismatch: client v0.11.0+df89e2c, server v0.12.4+1898f67                                                        
download the server version with: 'curl -L https://coder.com/install.sh | sh -s -- --version 0.12.4'

@ghuntley ghuntley mentioned this issue Nov 14, 2022
Closed
10 tasks
@matifali
Copy link
Member Author

matifali commented Dec 4, 2022

Still exists on 0.13.1

kylecarbs added a commit that referenced this issue Dec 14, 2022
@kylecarbs
fix: improve the warning mismatch to display the release assets on wi…
698f53f 
…ndows

Fixes #4226.
@kylecarbs kylecarbs mentioned this issue Dec 14, 2022
Merged
kylecarbs added a commit that referenced this issue Dec 14, 2022
@kylecarbs @mafredri
fix: improve the warning mismatch to display the release assets on wi…
8e702d8 
…ndows (#5418)

* fix: improve the warning mismatch to display the release assets on windows

Fixes #4226.

* Update cli/root.go

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

* Update cli/root.go

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve the warning mismatch to display the release assets on windows coder/coder
3 participants
@ghuntley @kylecarbs @matifali