-
Notifications
You must be signed in to change notification settings - Fork 881
Issues getting email with AzureAD OIDC integration #4472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We have a specific edge-case for this in v1, and I suppose we should add it in v2 as well! |
Thanks @kylecarbs. Still investigating our side as well to understand why it's sometimes not there. But good to know that there's edge cases previously encountered. |
Yes the OIDC spec says that the email field is optional so we should be able to handle not having it in general. 👍 |
FYI, we were able to resolve this with explictly setting |
Thanks @kylecarbs |
We've been having issues with onboarding users via AzureAD OIDC configuration which results in this error:
coder/coderd/userauth.go
Line 225 in adcf883
When testing
openid profile email
by default anid_token
comes back with the following.Have to manually add the email address field to the user in AzureAD portal for this to come back:
I'm just wondering if it should revert back to using
preferred_username
email address component if email is not there?Interesting note at: https://learn.microsoft.com/en-us/azure/active-directory/develop/active-directory-optional-claims#v10-and-v20-optional-claims-set
This is curious as I would have thought CoderV1 would have had similar issues?
The text was updated successfully, but these errors were encountered: