Skip to content

Fail to start for PostgreSQL <=12 #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kylecarbs opened this issue Oct 17, 2022 · 2 comments · Fixed by #4611 or #4612
Closed

Fail to start for PostgreSQL <=12 #4608

kylecarbs opened this issue Oct 17, 2022 · 2 comments · Fixed by #4611 or #4612

Comments

@kylecarbs
Copy link
Member

We don't support it, so we shouldn't succeed!
@ammario
Copy link
Member

ammario commented Oct 18, 2022

Context: I put a change in to fixed a "bug" that only showed up in PG11 but broke many deployments.

I've been using PG11 fine in my development environment for weeks, so it's possible we break deployments by adding a hard version check.

@ericpaulsen ericpaulsen mentioned this issue Oct 18, 2022
Merged
@kylecarbs
Copy link
Member Author

Our migration breaks it though, so if we don't add a hard-set check we risk breaking deployments in a worse way.

kylecarbs added a commit that referenced this issue Oct 18, 2022
@kylecarbs
chore: Enforce PostgreSQL >=13
544338d 
Fixes #4608.
@kylecarbs kylecarbs mentioned this issue Oct 18, 2022
Merged
kylecarbs added a commit that referenced this issue Oct 18, 2022
@kylecarbs
chore: Enforce PostgreSQL >=13 (#4612)
3c40698 
* chore: Enforce PostgreSQL >=13

Fixes #4608.

* Fix version string parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add postgres version requirement coder/coder
chore: Enforce PostgreSQL >=13 coder/coder
2 participants
@kylecarbs @ammario