Skip to content

audit: log update workspace events #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4726
Kira-Pilot opened this issue Oct 18, 2022 · 5 comments · Fixed by #5841
Closed
Tracked by #4726

audit: log update workspace events #4624

Kira-Pilot opened this issue Oct 18, 2022 · 5 comments · Fixed by #5841
Assignees

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Oct 18, 2022

If a template changes, the user may update an associated workspace, either in the CLI (coder update "workspace-1"), or in the UI:
Screen Shot 2022-10-18 at 1 38 46 PM

Additionally, in the future, we might make it possible for users to toggle between template versions in the UI.

We should audit these template version changes. One easy way might be to include the template_version_id in the workspace build diff, but we should check that 1) this works when we're updating via the CLI and 2) that this satisfies the product requirement, as we won't have a separate line item for workspace template changes.

@Kira-Pilot
Copy link
Member Author

contigent on #4625

@Kira-Pilot Kira-Pilot mentioned this issue Oct 24, 2022
41 tasks
@Kira-Pilot Kira-Pilot self-assigned this Oct 24, 2022
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 24, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2022
@Kira-Pilot Kira-Pilot reopened this Jan 3, 2023
@Kira-Pilot Kira-Pilot removed the stale This issue is like stale bread. label Jan 3, 2023
@Kira-Pilot
Copy link
Member Author

@bpmct A potentially easy way to do this would be to include the template version ID in the diff of the workspace build audit log line (imagine the below line item with a diff showing old and new template version ID):
Screen Shot 2023-01-04 at 5 21 01 PM

Would this be sufficient or do we need a distinct line item like "Admin started workspace build for foo with template version bar"?

@bpmct
Copy link
Member

bpmct commented Jan 11, 2023

The version ID in the diff is definitely a good start! We can just scope it to that for now

@Kira-Pilot
Copy link
Member Author

Resolved by #5841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants