Skip to content

Allow changing db schema from public #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Emyrk opened this issue Oct 25, 2022 · 1 comment · Fixed by #4873
Closed

Allow changing db schema from public #4747

Emyrk opened this issue Oct 25, 2022 · 1 comment · Fixed by #4873
Assignees
@mtojek
Labels
security Area: security

Comments

@Emyrk
Copy link
Member

Emyrk commented Oct 25, 2022

Problem

When creating our initial migration to bootstrap the database, we hard-code the schema name to public.

Solution

Do not set the schema name at all in the initial bootstrap script.
Allow this to be overridden via search_path in the connection string.

https://www.postgresql.org/docs/current/runtime-config-client.html

Private Link

V1 PR: https://github.com/coder/v1/pull/13216
v1 Issue: https://github.com/coder/v1/issues/13040
@mtojek
Copy link
Member

mtojek commented Nov 3, 2022

I will take this one as my first issue. I will keep you posted!

@mtojek mtojek self-assigned this Nov 3, 2022
@mtojek mtojek mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
security Area: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow changing db schema from public mtojek/coder
2 participants
@Emyrk @mtojek