Skip to content

Bug: "coder gitssh" not functional on 0.12.3 #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ssmiller25 opened this issue Nov 6, 2022 · 6 comments · Fixed by #4923
Closed

Bug: "coder gitssh" not functional on 0.12.3 #4921

ssmiller25 opened this issue Nov 6, 2022 · 6 comments · Fixed by #4923

Comments

@ssmiller25
Copy link
Contributor

Related to #4913 Upgraded to 0.12.3, created new EC2 Development environment, and still had the same issue. From the developer environment:

coder@dev-1106-1227:~$ coder version
Coder v0.12.3+267b81a Sun Nov  6 16:22:01 UTC 2022
https://github.com/coder/coder/commit/267b81af8320be9309382e1d8560b52f6e5c5de2
coder@dev-1106-1227:~$ git clone git@github.com:ssmiller25/r15cookieblog.git
Cloning into 'r15cookieblog'...
Cookie "coder_session_token" must be provided. Try logging in using 'coder login <url>'.
Run 'coder gitssh --help' for usage.                                                    
fatal: Could not read from remote repository.


Please make sure you have the correct access rights
and the repository exists.

Anything else I should look at? There was no issues with the 0.12.3 upgrade that I observed.

If it makes a difference, I am using Github OAuth for authentication.
@kylecarbs
Copy link
Member

Humph, something odd is happening here... I suppose my test didn't fix it. Looking now.

@kylecarbs
Copy link
Member

@ssmiller25 I did indeed make a mistake 🤦

coder/cli/agent.go

Lines 167 to 168 in 5be6c70

client.SessionToken = resp.SessionToken
return "", nil

Adding a test for this path now so it can never happen again!

@ssmiller25
Copy link
Contributor Author

No worries! Glad it was something you found quickly. And makes me really want to brush up on my Go skills :-)

kylecarbs added a commit that referenced this issue Nov 6, 2022
@kylecarbs
fix: Ensure the session token is properly passed to instance identity
904cff7 
Fixes #4921.
@kylecarbs kylecarbs mentioned this issue Nov 6, 2022
Merged
@kylecarbs
Copy link
Member

@ssmiller25 feel free to review to brush up the Go skills!

#4923

I appreciate you opening issues and being prompt with responses. I'll release 0.12.4, which I'm fully confident fixes this issue.

kylecarbs added a commit that referenced this issue Nov 6, 2022
@kylecarbs
fix: Ensure the session token is properly passed to instance identity (…
1898f67 
…#4923)

Fixes #4921.
@kylecarbs
Copy link
Member

@ssmiller25 0.12.4 is going up now! ~15mins

@ssmiller25
Copy link
Contributor Author

Worked perfectly. Thanks!

BobyMCbobs pushed a commit to sharingio/coder that referenced this issue Nov 8, 2022
@kylecarbs @BobyMCbobs
fix: Ensure the session token is properly passed to instance identity (…
054f757 
…coder#4923)

Fixes coder#4921.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure the session token is properly passed to instance identity coder/coder
2 participants
@kylecarbs @ssmiller25