Skip to content

support multiple OIDC email domains #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Nov 8, 2022 · 3 comments
Closed

support multiple OIDC email domains #4961

bpmct opened this issue Nov 8, 2022 · 3 comments

Comments

@bpmct
Copy link
Member

bpmct commented Nov 8, 2022 •
edited
Loading

Currently, you can only define one with coder server --oidc-email-domain. Let's allow multiple similar to CODER_OAUTH2_GITHUB_ALLOWED_ORGS
@dcarrion87
Copy link
Contributor

dcarrion87 commented Nov 24, 2022 •
edited
Loading

AzureAD guests wanting to get into one of our coder instances get this:

{"message":"Your email "REDACTED@REDACTED" is not a part of the "REDACT.REDACTED" domain!"}

Without ability to allow multiple domains this is a blocker for us.

@dcarrion87
Copy link
Contributor

@bpmct @kylecarbs is this a relatively quick fix?

We've got 3 users now across tenants wanting to do this but blocked due to domain.

@dcarrion87
Copy link
Contributor

Have raised a PR: #5210

@bpmct bpmct closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcarrion87 @bpmct