Skip to content

Give CODER_ACCESS_URL a sane default #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #4628
ElliotG opened this issue Nov 11, 2022 · 2 comments
Closed
Tracked by #4628

Give CODER_ACCESS_URL a sane default #5024

ElliotG opened this issue Nov 11, 2022 · 2 comments

Comments

@ElliotG
Copy link
Contributor

ElliotG commented Nov 11, 2022 •
edited
Loading

What's the problem

  • Use the Helm chart to deploy on GKE
  • Log into Coder and set up the initial org/accounts
  • Try to launch a workspace, and it will fail to download the agent

The issue is that CODER_ACCESS_URL isn't set. Unfortunately, when you are installing via Helm, you don't know the IP address of the coder service until after the chart is applied. This leaves you with an awkward "deploy the stack, grab the IP address, and then redeploy the stack".

The Helm chart install is likely the first step of the game to using coder for the first time, and this is the only thing standing in the way of a flawless onboarding experience.

My recommendation:

If CODER_ACCESS_URL is not explicitly set, give it a default value of the coder service host. The end result should be that you can apply the Helm chart and have a working Coder stack.
@bpmct
Copy link
Member

bpmct commented Nov 14, 2022

If unset, Coder will actually leverage the public tunnel as an access URL, which negates the purpose of the LoadBalancer which the helm chart provisions by default.

I agree we need a better sensible default and I like your recommendation. If, for some reason, we cannot default it to the LoadBalancer IP, perhaps we should disable the LoadBalancer by default (serviceType: ClusterIP) and change the docs to help users find their tunnel URL.

@bpmct bpmct mentioned this issue Nov 14, 2022
Closed
13 tasks
@bpmct
Copy link
Member

bpmct commented Nov 14, 2022

Looks like this was already done by using the internal address #5041 🧠

@bpmct bpmct closed this as completed Nov 14, 2022
@hh hh mentioned this issue Mar 10, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElliotG @bpmct